Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable pdf bulk export #9283

Open
wants to merge 16 commits into
base: feat/135772-pdf-page-bulk-export
Choose a base branch
from
Open

enable pdf bulk export #9283

wants to merge 16 commits into from

Conversation

arafubeatbox
Copy link
Contributor

@arafubeatbox arafubeatbox commented Oct 20, 2024 •
edited
Loading

仕様書

https://dev.growi.org/66ee8495830566b31e02c953#growi

task

https://redmine.weseek.co.jp/issues/153348

備考

  • base branch は feat/page-bulk-export ではなく、feat/135772-pdf-page-bulk-export

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7ee3eaf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@arafubeatbox arafubeatbox mentioned this pull request Oct 20, 2024
Merged
Base automatically changed from feat/135772-155547-pdf-converter-tsed-devcontainer to feat/135772-pdf-page-bulk-export November 11, 2024 13:37
@arafubeatbox arafubeatbox marked this pull request as ready for review November 12, 2024 10:39
yuki-takei
yuki-takei requested changes Nov 21, 2024
View reviewed changes
apps/app/src/features/page-bulk-export/server/service/page-bulk-export/index.ts
.toString();

return htmlString;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remark().use(html) で得られるインスタンスは保持して使い回した方がいいんじゃないかな
どこまで差が出るかはわからないけど

apps/app/src/features/page-bulk-export/server/service/page-bulk-export/index.ts
}
}, 60 * 1000 * 1);
});
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このメソッドはレビューしきれてないので引き続き

apps/app/turbo.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slackbot-proxy を起動しなくても app が使えるように、
pdf-converter もまた app の起動に必須ではないので、dependsOn からは外してほしい。

開発時に開発者がやらないといけないことはマニュアルに書いて周知する。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuki-takei yuki-takei yuki-takei requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arafubeatbox @yuki-takei