Upgrade from Python 3.6 to 3.7 #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [onnx-chainer](https://github.com/chainer/onnx-chainer) from 1.4.1 to 1.5.0. Adds support for python 3.7!! - [Release notes](https://github.com/chainer/onnx-chainer/releases/tag/v1.5.0) - [Commits](chainer/onnx-chainer@v1.4.1...v1.5.0)
weiji14
added
dependencies
Github Actions can now do proper Ci/CD, see announcement at https://github.blog/2019-08-08-github-actions-now-supports-ci-cd/! Semi-automatically migrating the old main.workflow to a push.yml using https://github.com/actions/migrate/releases/tag/2019-08-06%4020-47, see also https://help.github.com/en/articles/migrating-github-actions-from-hcl-syntax-to-yaml-syntax. Deprecate use of actions/docker/cli (just use actions/checkout which has docker?) and manually edited the 'runs-on' to 'ubuntu-18.04' aka Bionic Beaver instead of 'ubuntu-latest'.
Closes #163 Convert Github Actions from V1 HCL syntax to V2 YAML syntax.
Bumps [python](https://github.com/python/cpython) from 3.6.7 to 3.7.3. Had to change pip in the conda environment.yml to use the py37 version, plus update the hash in the Pipfile.lock. Also added HDF5_DIR environment variable to get `pip install netcdf4` to work! - [Release notes](https://github.com/python/cpython/releases/tag/v3.7.3) - [Changelog](https://docs.python.org/3/whatsnew/3.7.html) - [Commits](python/cpython@3.6...3.7)
Keeping our main README.md file a bit more up to date! Updated installation instructions for the conda 4.7 (#161) python 3.7 world (a lot better than conda 4.6 and python 3.6), and made sure to set the HDF5_DIR environment variable as in c80041d to install [netCDF4](https://github.com/Unidata/netcdf4-python) properly. Also refreshed some of those outdated descriptions of the files we have in our repository's directory structure!
Owner
Author
|
Could have updated netcdf4 from 1.4.1 to 1.5.1.2, but that would require compiling the netcdf4-python package from source. No easy way to specify that in the Pipfile, but we could use the but that won't be accurately reflected in the Pipfile.lock (?) that would undermine reproducibility as compiling the package at different times (with different compilers) may yield slightly different Wait, but sticking to netcdf==1.4.1 and using python 3.7 still means we are compiling it (that's why we see this and also why |
weiji14
added a commit
that referenced
this pull request
Aug 14, 2019
Closes #162 Upgrade from Python 3.6 to 3.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of new goodies in Python 3.7! Mainly nice to haves e.g. better parallelization with improved
asynciousability viaasyncio.run(), easier debugging usingbreakpoint(), etc. Most of this DeepBedMap's dependencies have supported Python 3.7 for months already, all exceptonnx-chainerbut that's changed with chainer/onnx-chainer#192. Woohoo!TODO:
environment.ymlandPipfile(c80041d).Try to update netcdf4 from 1.4.1 to 1.5.1.2, pinned since a84dfd6 (see also ⬆️ Bump netcdf4 from 1.4.1 to 1.4.2 #58)