Skip to content

Conversation

@weiji14
Copy link
Owner

@weiji14 weiji14 commented Aug 12, 2019

Github Actions can now do proper Ci/CD, see announcement at https://github.blog/2019-08-08-github-actions-now-supports-ci-cd/! Semi-automatically migrating the old main.workflow to a push.yml using https://github.com/actions/migrate/releases/tag/2019-08-06%4020-47, see also https://help.github.com/en/articles/migrating-github-actions-from-hcl-syntax-to-yaml-syntax. Deprecate use of actions/docker/cli (just use actions/checkout which has docker?) and manually edited the 'runs-on' to 'ubuntu-18.04' aka Bionic Beaver instead of 'ubuntu-latest'.
@weiji14 weiji14 added enhancement ✨ New feature or request dependencies Pull requests that update a dependency file docker 🐳 Pull requests that update Docker code labels Aug 12, 2019
@weiji14 weiji14 added this to the v0.9.4 milestone Aug 12, 2019
@weiji14 weiji14 self-assigned this Aug 12, 2019
@weiji14 weiji14 marked this pull request as ready for review August 12, 2019 22:41
@weiji14
Copy link
Owner Author

weiji14 commented Aug 12, 2019

Failures at Cell 1 data_prep.ipynb unit test and Cell 3 data_prep.ipynb integration test due to the CRESIS data server being down. Merging in anyway!

@weiji14 weiji14 merged commit 591015a into python_3.7 Aug 12, 2019
@weiji14 weiji14 deleted the github-actions/migrate_v2 branch August 12, 2019 22:46
weiji14 added a commit that referenced this pull request Aug 12, 2019
Closes #163 Convert Github Actions from V1 HCL syntax to V2 YAML syntax.
@weiji14
Copy link
Owner Author

weiji14 commented Aug 14, 2019

CRESIS server back up, and rerunning the tests pass at https://github.com/weiji14/deepbedmap/runs/192913353!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file docker 🐳 Pull requests that update Docker code enhancement ✨ New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant