Changed deprecated slot syntax #360
Conversation
|
Hi @sronveaux, thanks a lot for providing this! I`m unfortunately a bit short currently for a full review but will do either in the upcoming weeks or maybe @chrismayer can?! Do the commits 607c6a3 and 49ea5f3 relate to slot syntax changes? Greets Felix |
sronveaux
force-pushed
the
new-slot-syntax
branch
from
49ea5f3
to
3d82608
Compare
|
Hi @fschmenger and thanks for the comment, no problem, there is no hurry, this will be useful later when updating to Concerning the two commits, it was kind of linked because when updating the workshop documentation with the new syntax, I came across the fact that the workshop code couldn't be run anymore because of linting errors. So it was no point to change just the slot syntax but have a code that can't be run on current version of Wegue... No problem, this PR now just changes the slot syntax in code and documentation and I'm going to create another PR with the updates to the workshop... Greets, Sébastien |
There was a problem hiding this comment.
Hi @sronveaux,
I tested this in a custom App which makes extensive use of tooltips / map-overlays. I also tested some of the slots which are forwarded to the app-header.
Everything works as expected.
Thank you, will merge this now.
In the wake of #359 there is a small PR which gets rid of the
slotandslot-scopeattributes which are strongly discouraged since Vue 2.6 and deprecated in Vue 3.This PR was made as a small step towards #350 and #351 and is in fact the preliminary step before migrating to Vue 3 as stated in the official migration guide.
This should have no impact on any working Wegue application as deprecated syntax can still be used next to the new one but it should be tested on bigger and more complete apps just to be sure...