Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vue 3 #350

Open
chrismayer opened this issue Oct 18, 2023 · 3 comments
Open

Upgrade to Vue 3 #350

chrismayer opened this issue Oct 18, 2023 · 3 comments
Labels
dependecy upgrade Upgrade of a code dependency

Comments

@chrismayer
Copy link
Collaborator

Since "Vue 2 will reach End of Life (EOL) on December 31st, 2023" (see https://v2.vuejs.org/lts/) we should tackle the upgrade of the code base to Vue 3. Even tough offering different new concepts in Vue 3 one could stay at the classic component approach of Vue 2. So the upgrade effort should be OK besides the normal upgrade madness, but no complete re-write.

@sronveaux
Copy link
Collaborator

Hi team,

I have to tell I already looked at this last year as this was some sort of natural follow-up of migrating to the latest Vue-CLI but what stopped me was the lack of compatibility of Vuetify at that time.

From a completely personal point of view, I'm not looking at it for now neither because Vuetify3 still lacks some components which were available in V2. This would force me to stop upgrading Wegue inside my main project which unfortunately makes use of some of those.

After some reading though, it seems there can be a possibility to upgrade Vue only using the compat migration build which could potentially still work with Vuetify2. The migration build could then be entirely replaced by Vue3 once Vuetify will be complete enough to be migrated too...

For the rest, as @chrismayer said, we should be able to stay with the Options API and migrate without too much trouble, the main difficulty will be to replace the WguEventBus as this way of working is not possible as is anymore. There exists some possibilities to reach the same behaviour like the excellent mitt for example.

@JakobMiksch
Copy link
Collaborator

the main difficulty will be to replace the WguEventBus

in Vue 3 it is possible to store state like a map in composables or with the "official" state management library "pinia"

@JakobMiksch
Copy link
Collaborator

For sharing the map state across components in Vue 3, I find composables quite useful.
Here a library with included demo project, that could be of interest of the next generation of Wegue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependecy upgrade Upgrade of a code dependency
Projects
None yet
Development

No branches or pull requests

3 participants