Generic toolbar buttons #207
Conversation
The management of visibility states has to be changed to a global event bus based implementation, as the existing concept no longer works with inheritance.
…v-cards to support all of its properties.
…ow is no longer modal.
…sitioning behavior.
…n resources in app-conf.json. As a side effect the orientation of the toolbar menu is currently vertical.
…tter UI consistency.
…ric-window-management
…f the module has changed, which can be consumed by the parent class. This is more convenient than listening to the event on the global event bus and fixes a bug in AttributeTableWin, when the global event was consumed by the parent class before the actual module visibility is toggled.
…nger/wegue into generic-toolbar-buttons
|
Some further notes:
|
There was a problem hiding this comment.
LGTM, thnaks for this @fschmenger. I added 2 minor (non-blocking) comments you might want to address before merging
app-starter/components/AppHeader.vue
Outdated
| @@ -24,26 +24,29 @@ | |||
| <component | |||
| :is="tbButton.type" :key="index" | |||
| :icon="tbButton.icon" :text="tbButton.text" | |||
| :color="color" | |||
| :dark="tbButton.dark" | |||
| :dark="tbButton.dark" :moduleName="tbButton.moduleName" | |||
app-starter/components/AppHeader.vue
Outdated
| /> | ||
| </template> | ||
|
|
||
| <!-- slot to inject components after the auto-generated buttons (by config) --> | ||
| <slot name="wgu-tb-after-auto-buttons"></slot> | ||
|
|
||
| <v-menu v-if="menuButtons.length" offset-y> | ||
| <v-menu v-if="menuButtons.length" offset-y nudge-bottom="15"> | ||
| <!--v-slot="activator" to v-slot:activator="{on}" --> |
There was a problem hiding this comment.
Can this line be removed?
There was a problem hiding this comment.
Regarding this change:
One implication of wrapping buttons by a toggle-group is, that the orientation of the hamburger menu is now vertical. So I inserted a little offset such that it is not showing on top of the toolbar. IMO it doesn’t look very nice without it, but I can certainly remove it.
There was a problem hiding this comment.
My question was with regard to the commented line. Not the line above. The vertical menu is fine.
There was a problem hiding this comment.
The commented line was not introduced by me.
If you ask me it can be certainly removed. I can do that now.
There was a problem hiding this comment.
Oh sorry - didn't want to blame you 😉 . Yes, would be cool, if you could remove this line.
|
Thanks for your ongoing effort @fschmenger. This is good to go now. For transparency: There will be some more PRs tackling some refactoring tasks. The last step will be to adjust the unit tests at once to avoid duplicate work, so it is a know issue that this (and some follow ups) will break the test suite of the master branch for a couple days. |
This adds a generic toggle button as a Wegue component, which replaces redundant implementations of each toggle button for the individual modules. As a consequence, the modules icon resource now has to be declared in app-conf.json.