Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a windowed option for geocoder #243

Open
fschmenger opened this issue Sep 2, 2021 · 1 comment
Open

Support a windowed option for geocoder #243

fschmenger opened this issue Sep 2, 2021 · 1 comment

Comments

@fschmenger
Copy link
Collaborator

I propose to introduce support for running the UI of geocoder in a floating and sidebar window. This is a follow up task to standardising the behavior of toolbar-buttons and modules, which was started with #206 and #207.

For a proof of concept implementation I introduced a new module card attribute "winHeader": false to disable the window toolbar - name of the attribute is subject to discussion. Here's an example for the module definitions and a corresponding screenshot:

Wegue_geocoder_floating

 "modules": {
    "wgu-geocoder": {
     "target": "toolbar",
      "win": "floating",
      "winHeader": false,
      "icon": "search",
      "initPos": {
        "left": 8,
        "top": 74
      },
      ......
   }
}

Wegue_geocoder_sidebar

 "modules": {
    "wgu-geocoder": {
      "target": "toolbar",
      "win": "sidebar",
      "winHeader": false,
      "icon": "search",
      ......
   }
}
@fschmenger
Copy link
Collaborator Author

@chrismayer
My question regarding this: Do we want to support placement of the geocoder searchbar on the Wegue toolbar in the future?

In my opinion this is not a great solution, because

  • it scales bad on devices with small screen width
  • all toolbar-buttons currently support the target": "menu" option. If this is set for the geocoder, it breaks the layout of the hamburger menu.

Even though I got a prototype to work, a generical switch between placing content on the toolbar and on a card is pretty cumbersome to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant