Skip to content

fix(wework): default composer to two lines - #2732

Merged
qdaxb merged 1 commit into
mainfrom
fix/wework-composer-default-height
Aug 16, 2026
Merged

qdaxb merged 1 commit into
mainfrom
fix/wework-composer-default-height

Conversation

@qdaxb

@qdaxb qdaxb commented Aug 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • make the default desktop composer start at two text lines
  • keep the compact composer at one line
  • document the composer height contract and add regression assertions

Root cause

The desktop project composer explicitly used one row and a 32px minimum height, so it rendered with the same initial density as compact mode.

Validation

  • pnpm --filter wework test src/components/chat/ChatInput.test.tsx (109 passed)
  • focused Prettier and ESLint checks
  • pre-push Wework ESLint, TypeScript, and unit tests
  • isolated real Tauri verification: desktop composer reports rows=2 and 48px height

Summary by CodeRabbit

  • Enhancements
    • Desktop chat composers now open with two lines of space for easier message composition.
    • The desktop editor has a taller minimum height, while compact mobile composers continue to start with one line and expand as needed.
  • Tests
    • Updated coverage to reflect the new desktop and mobile composer sizes.

@qdaxb
qdaxb enabled auto-merge August 16, 2026 16:26
@coderabbitai

coderabbitai Bot commented Aug 16, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3a8c210b-59fb-4cf9-b1d7-4bdbaff4c85b

📥 Commits

Reviewing files that changed from the base of the PR and between ee86dba and 1757f97.

📒 Files selected for processing (3)
  • wework/DESIGN.md
  • wework/src/components/chat/ChatInput.test.tsx
  • wework/src/components/chat/composer/ProjectChatComposer.tsx

Included review availability: Your plan includes up to 4 reviews per rolling hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The desktop composer now starts at two rows with a 12rem minimum height. Compact composers remain single-row inputs. Tests and the Composer specification reflect these sizing rules.

Changes

Composer sizing

Layer / File(s) Summary
Desktop composer sizing
wework/src/components/chat/composer/ProjectChatComposer.tsx
ComposerTextarea now defaults to two rows and uses min-h-12.
Sizing contract and coverage
wework/DESIGN.md, wework/src/components/chat/ChatInput.test.tsx
The specification and tests describe and verify two-row desktop inputs and one-row compact inputs.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 1757f

This change only adjusts the desktop composer’s default height while preserving compact mode behavior and adds regression coverage; no actionable merge-blocking risk remains.

Possibly related PRs

Suggested reviewers: micro66, icycrystal4

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: setting the Wework composer default to two lines.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/wework-composer-default-height

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb added this pull request to the merge queue Aug 16, 2026
Merged via the queue into main with commit 3683b07 Aug 16, 2026
46 checks passed
@qdaxb
qdaxb deleted the fix/wework-composer-default-height branch August 16, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant