Repository navigation
fix(wework): stabilize runtime task visibility and ordering - #2017
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughRuntime tasks now carry completion timestamps through executor state, API responses, and sidebar sorting. Codex indexing filters for manual thread ordering, and project grouping can use persisted worktree source paths. ChangesRuntime task ordering and metadata
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Executor
participant RuntimeTaskSummary
participant Sidebar
Executor->>Executor: Record completed_at for terminal tasks
Executor->>RuntimeTaskSummary: Serialize completedAt
RuntimeTaskSummary->>Sidebar: Provide runtime task metadata
Sidebar->>Sidebar: Sort by completedAt before fallback timestamps
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qdaxb
marked this pull request as ready for review
July 17, 2026 07:22
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
updatedAtchanges do not move sidebar rowsRoot cause
The runtime task filter recomputed a worktree's project root from live
.gitmetadata on every refresh. When that metadata was temporarily unavailable, the worktree path could not be mapped back to its project and the task was omitted from the response. Separately, the sidebar used providerupdatedAtand non-manual thread order, both of which can change while chunks stream.Impact
Tasks remain visible across transient worktree metadata failures. In automatic sort mode, a running conversation keeps its previous position while chunks stream and moves only after the turn completes. Explicit manual ordering remains unchanged.
Validation
pnpm --filter wework test— 177 files, 1747 tests passedcd executor && cargo test --quiet— full suite passedpnpm --filter wework typecheckSummary by CodeRabbit
Improvements
Bug Fixes