Skip to content

fix(executor): isolate Codex from runtime IPC - #2001

Merged
qdaxb merged 1 commit into
mainfrom
fix_ipc_loss
Jul 16, 2026
Merged

qdaxb merged 1 commit into
mainfrom
fix_ipc_loss

Conversation

@qdaxb

@qdaxb qdaxb commented Jul 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes

    • Improved process isolation when launching Codex services by preventing executor-specific environment settings from being unintentionally inherited.
    • Reduced the risk of configuration conflicts between the executor and launched services.
  • Tests

    • Improved test isolation by using temporary IPC address files and cleaning them up automatically after test runs.

@qdaxb
qdaxb merged commit 399e8f3 into main Jul 16, 2026
9 of 10 checks passed
@qdaxb
qdaxb deleted the fix_ipc_loss branch July 16, 2026 16:57
@coderabbitai

coderabbitai Bot commented Jul 16, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 53ea2fdd-8abf-489d-809f-84a2b69e0f8b

📥 Commits

Reviewing files that changed from the base of the PR and between 63892d9 and 7785cba.

📒 Files selected for processing (2)
  • executor/src/agents/codex.rs
  • executor/tests/local_app_ipc_contract.rs

📝 Walkthrough

Walkthrough

The executor now strips internal environment variables before launching Codex’s app-server. Local app IPC contract tests use unique temporary address files and clean up those files and directories afterward.

Changes

Codex app-server environment sanitization

Layer / File(s) Summary
Remove executor environment keys during app-server spawn
executor/src/agents/codex.rs
Defines executor-internal environment keys and removes them from the Codex app-server child process before configured environment overrides are applied.

Local app IPC test isolation

Layer / File(s) Summary
Isolate IPC address-file overrides in contract tests
executor/tests/local_app_ipc_contract.rs
Both async IPC server tests use unique temporary app-ipc.addr paths through WEGENT_EXECUTOR_APP_IPC_ADDR_FILE and remove the temporary files and parent directories during cleanup.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: sdadunderscoresdad

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_ipc_loss

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant