Repository navigation
feat(wework): add Windows desktop support - #1950
Conversation
- Replace Unix domain sockets with TCP loopback for Executor IPC - Use dirs::home_dir() for cross-platform home directory resolution - Add Windows executable and binary resolution with fallback paths - Add PowerShell support for local terminal - Gate macOS-only features (process diagnostics, screenshots, CLI launcher) - Add Windows build scripts and NSIS installer hooks - Add Windows tray icon handling Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (40)
📝 WalkthroughWalkthroughThis change adds Windows build and packaging workflows, migrates local Executor IPC from Unix sockets to TCP address files, adds Windows terminal and tray support, improves cross-platform path and executable discovery, and documents native and macOS cross-compilation procedures. ChangesWindows desktop support
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant WeWork as Tauri local_executor
participant Executor as Windows Executor
participant AddrFile as app-ipc.addr
WeWork->>Executor: launch sidecar
Executor->>AddrFile: write TCP loopback address
WeWork->>AddrFile: read resolved address
WeWork->>Executor: connect over TCP
Executor-->>WeWork: ready event and responses
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Add native Windows desktop support for
weworkand the local Executor sidecar while keeping existing macOS behavior unchanged.127.0.0.1:0, writes the bound address to~/.wegent-executor/app-ipc.addr, and Tauri reads that file to discover the port.dirs::home_dir()for cross-platform home directory resolution so Windows usesUSERPROFILEinstead of relying on theHOMEenvironment variable.codex.exe,.cmd,.bat,.com) and fallback search paths for npm/cargo binaries when the GUI process does not inherit shellPATH.pwsh.exefirst and falling back topowershell.exe.#[cfg(target_os = "macos")].tauri.windows.conf.json).wework/scripts/build-windows-app.sh,build-windows-sidecar.sh,patch-windows-nsis.py) and NSIS installer hooks to kill running sidecar processes before upgrade.docs/en/developer-guide/wework-windows.mdanddocs/zh/developer-guide/wework-windows.md.Test plan
cd wework && pnpm run build:windowssucceeds on macOS and produces the NSIS installer.WeWork_0.0.15_x64-setup.exeon Windows 10/11.~/.wegent-executor/app-ipc.addr.pnpm exec tauri dev) still works and no macOS-only helpers leak into Windows builds.🤖 Generated with Claude Code
Summary by CodeRabbit