Apply patches to m97 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion allow listen-only mode in AudioUnit, adjust when category changes
Simulcast support for iOS SDK
Support for simulcast in Android SDK
* use `AVAudioSession` defaults * remove isRecordingEnabled
* Add Apache-2.0 license and some notes to README.md. * Add user link. * update.
davidzhao
approved these changes
Feb 9, 2022
Member
davidzhao
left a comment
davidzhao
left a comment
There was a problem hiding this comment.
Looks good! I've enabled individual commit merging for the repo. that might be a better way to move forward to keep them separate. wdyt?
Contributor
Author
|
What's individual commit merging, and how does that differ? |
Member
|
it will keep all the commits in main individually, rather than all together. It might make it easier to cherry pick changes to future branches |
Contributor
Author
|
Ah, instead of squashing, got it. |
Member
|
Nice !! No more simulcast factory null checks for android 🙂 |
Contributor
Author
|
The null checks were originally from upstream so they're taken care of now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: PRs #11 and #12 were dropped as they were patches originally taken from the upstream, and are no longer needed.