Skip to content

Add onRemoveTrack for Android.#12

Merged
cloudwebrtc merged 1 commit intomainfrom
add_onremovetrack_for_android
Oct 27, 2021
Merged

Add onRemoveTrack for Android.#12
cloudwebrtc merged 1 commit intomainfrom
add_onremovetrack_for_android

Conversation

@cloudwebrtc
Copy link
Member

@cloudwebrtc cloudwebrtc commented Oct 27, 2021

@davidzhao
Copy link
Member

should we just upstream a later version of webrtc? The method exists in later versions of the repo. It seems that'd be more reliable versus integrating a patch.

@cloudwebrtc
Copy link
Member Author

cloudwebrtc commented Oct 27, 2021

should we just upstream a later version of webrtc? The method exists in later versions of the repo. It seems that'd be more reliable versus integrating a patch.

https://webrtc.googlesource.com/src/+/ffbfba979f9d48176c7ed5dcc60b6a8076303b71
@davidzhao This makes sense, I will re-push the patch

@cloudwebrtc cloudwebrtc force-pushed the add_onremovetrack_for_android branch from e6463c3 to 62668ad Compare October 27, 2021 04:21
@cloudwebrtc
Copy link
Member Author

@davidzhao I temporarily updated the patch, we can try to fetch upstream. so that the main branch can be upgraded to a higher version.

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a plan!

@cloudwebrtc
Copy link
Member Author

@cloudwebrtc cloudwebrtc merged commit 9a49711 into main Oct 27, 2021
@cloudwebrtc cloudwebrtc deleted the add_onremovetrack_for_android branch October 27, 2021 04:41
@davidliu davidliu mentioned this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants