-
-
Notifications
You must be signed in to change notification settings - Fork 61
Update meters & simplify execution minutes formatting #3021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update meters & simplify execution minutes formatting #3021
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
| --darkened-background-color-1: oklch( | ||
| from var(--background-color) calc(l - 0.2) c h | ||
| ); | ||
| --darkened-background-color-2: oklch( | ||
| from var(--background-color) calc(l - 0.1) calc(c + 0.1) h / 0.5 | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relative colour syntax is widely supported now! These don't quite match the colour of the .valueBar::before outline (line 150) that uses mix-blend-mode: color-burn, but it's close enough for this use case.
9fa5509 to
febe01f
Compare
fixes an issue where usage history would be incorrectly clamped to the sum of available quota seconds when monthly quota is unlimited
move execution and storage meters to separate subdirectories with shared colors, tooltip utilities, and rendering helpers. remove unused divided meter bar implementation and consolidate color definitions. standardize renderBar props to use structured color objects and introduce legend utilities for consistent color rendering across meters. update import paths to reflect new directory structure.
08e8a4b to
03b84fd
Compare
9e87411 to
5e3878f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice upgrade, love those popovers.
Minor comments, one overall impression is that when there is no usage, the saturated light green stands out to me in a way that is slightly confusing. It seems overly significant since the storage bar is desaturated:
Since the background of the current meters are gray, it's less intrusive:
Maybe we should hide the meter altogether if there is no usage and just show "X min remaining"? Since this is the view that all new users will see, I think it's worth considering this as the first impression.
That's a good point, what might actually be simpler here is just hiding the background components and just showing a simple "available" popup like the storage meter. I'll take a go at it! |




Closes #3020
Merges into #2944
Changes
Meters
Reimplements meters for the dashboard & the Billing & Usage section of the org dashboard
Screen.Recording.2025-12-02.at.8.36.00.PM.mov
Execution minute formatting
Simplifies the execution minute formatting logic, now no longer showing values twice with different detail levels.
Org Settings
As part of the changes to implement additional minute add-on purchases, this converts the Billing section of the Org Settings to Billing & Usage, and adds usage meters. Eventually this will be where billing history will also be displayed.
When no quota is set, Usage sections show usages as plain values.