Add-on minute checkout session setup #2944
Conversation
emma-sg
force-pushed
the
additional-minutes-addon-purchase
branch
2 times, most recently
from
4ee2020 to
82a6295
Compare
emma-sg
force-pushed
the
additional-minutes-addon-purchase
branch
from
5ad2648 to
93fd027
Compare
emma-sg
force-pushed
the
additional-minutes-addon-purchase
branch
4 times, most recently
from
e583fe7 to
9fa5509
Compare
emma-sg
force-pushed
the
additional-minutes-addon-purchase
branch
from
9fa5509 to
febe01f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Working well on dev, with a really smooth user experience. I left a few comments. I am leaning with Emma toward handling the org quota update in a transaction as the right approach here, as long as the effort isn't prohibitive (in which case #2999 seems like a good option to tide us over for now, but maybe with some more comments to help devs reading the code walk through the business logic of the aggregation). It might also be good to use this opportunity to improve our test coverage for the update quota method a little bit regardless of which path we take to test edge cases like attempting to set a quota below 0 in an update. |
- add get_checkout_url method to create checkout session for additional minutes - add /checkout/execution-minutes endpoint to handle addon purchase requests (this will need to be updated in dev/prod playbooks) - update CI workflows to remove portalUrl suffix from secret value - add test endpoint in echo server to mock checkout response
…o buy more minutes
- handle minutes purchased via SubscriptionAddMin event - use /subscriptions/add-minutes endpoint to add additional minutes
- remove context - total_price -> totalPrice - context -> paymentId - store subEventId in quota update, linking to subscription event id - org fields: don't include subEventId in org quota updates output, add OrgQuotaUpdateOut for this
emma-sg
force-pushed
the
additional-minutes-addon-purchase
branch
from
261f9b8 to
43bb583
Compare
To be merged into #2944 Adds a causally consistent session specifically to the quota update method so that its three operations can operate more-or-less atomically. We'd looked at doing this with a transaction, but they require a replica set or sharding, which isn't always included in self-hosted Browsertrix deployments. For now this should improve reliability for the multi-operation `update_quotas` method, even if it's not perfectly atomic — it's pretty unlikely at the scale we're working with here for there to be multiple simultaneous operations for a single org. Tested with local deployment. --------- Co-authored-by: Ilya Kreymer <[email protected]>
as discussed in discord
ikreymer
left a comment
ikreymer
left a comment
There was a problem hiding this comment.
Nice work! Tested extensively on dev and working as expected. Nice improvements to the meter rendering as well.
ikreymer
left a comment
ikreymer
left a comment
There was a problem hiding this comment.
Nice work! Tested extensively on dev with test accounts, working as expected, and new meter rendering is a significant improvement as well!
Supports purchase of additional minutes by the org admin, fixes #3051
Waiting on these PRs to be merged into this:
Refactor quota updates to use aggregation pipeline #2999