Delay rendering components doing data fetching in collection settings dialog until open #2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emma-sg
force-pushed
the
frontend-optimize-editing-dialog-loading
branch
from
424877d to
8a31a23
Compare
Member
Author
|
That's weird, why'd the auth service test fail 🤔 |
ikreymer
merged commit 77caa40
into
issue-2406-crawl-migration-rework
25 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delays rendering contents of the collection settings dialog until actually needed. Various fetches that internal components were running were causing slowdowns in other parts of the app, so this should resolve some of that.