Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use own inquirer implementation #2538

Merged
merged 6 commits into from
Apr 7, 2021
Merged

feat: use own inquirer implementation #2538

merged 6 commits into from
Apr 7, 2021

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
No

Summary
Uses inquirer for prompt, same as yeoman-env

Does this PR introduce a breaking change?
No

Other information

@anshumanv anshumanv requested a review from a team as a code owner March 22, 2021 15:53
@anshumanv
Copy link
Member Author

Don't know how it got introduced, only PR I can find is #1362 which was not merged

@snitin315
Copy link
Member

snitin315 commented Mar 22, 2021

Here #1237 , thanks to git blame

@alexander-akait
Copy link
Member

hm, what about don't use migrate and inquirer inside webpack-cli package and implement logic on own side - less deps, less problems, less size, also we use it only in one place https://github.com/webpack/webpack-cli/blob/master/packages/webpack-cli/lib/utils/prompt-installation.js

@anshumanv
Copy link
Member Author

Yes can think of own inquirer 🤔

@anshumanv anshumanv changed the title chore: migrate to inquirer chore: use own inquirer implementation Apr 6, 2021
@anshumanv anshumanv changed the title chore: use own inquirer implementation feat: use own inquirer implementation Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #2538 (c943f00) into master (3a5cf10) will increase coverage by 2.24%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2538      +/-   ##
==========================================
+ Coverage   91.35%   93.60%   +2.24%     
==========================================
  Files          29       37       +8     
  Lines        1480     1672     +192     
  Branches      425      461      +36     
==========================================
+ Hits         1352     1565     +213     
+ Misses        128      107      -21     
Impacted Files Coverage Δ
packages/webpack-cli/lib/utils/prompt.js 54.54% <54.54%> (ø)
...kages/webpack-cli/lib/utils/prompt-installation.js 73.91% <100.00%> (ø)
packages/generators/src/plugin-generator.ts 85.71% <0.00%> (-14.29%) ⬇️
packages/generators/src/loader-generator.ts 91.66% <0.00%> (ø)
test/api/resolveConfig/webpack.config.cjs 100.00% <0.00%> (ø)
test/api/resolveConfig/webpack.config2.cjs 100.00% <0.00%> (ø)
test/utils/test-utils.js 85.03% <0.00%> (ø)
test/api/resolveConfig/webpack.promise.config.cjs 100.00% <0.00%> (ø)
test/api/resolveConfig/env.webpack.config.cjs 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a5cf10...c943f00. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@alexander-akait
Copy link
Member

/cc @webpack/cli-team

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alexander-akait alexander-akait merged commit a3eaeee into master Apr 7, 2021
@alexander-akait alexander-akait deleted the chore/inq branch April 7, 2021 14:22
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants