-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use own inquirer implementation #2538
Conversation
Don't know how it got introduced, only PR I can find is #1362 which was not merged |
Here #1237 , thanks to |
hm, what about don't use |
Yes can think of own inquirer 🤔 |
Codecov Report
@@ Coverage Diff @@
## master #2538 +/- ##
==========================================
+ Coverage 91.35% 93.60% +2.24%
==========================================
Files 29 37 +8
Lines 1480 1672 +192
Branches 425 461 +36
==========================================
+ Hits 1352 1565 +213
+ Misses 128 107 -21
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
/cc @webpack/cli-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Thanks |
What kind of change does this PR introduce?
chore
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
Uses inquirer for prompt, same as yeoman-env
Does this PR introduce a breaking change?
No
Other information