Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: post refactor CLI #1237

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Feb 18, 2020

What kind of change does this PR introduce?

Refactor:

  • moved the cli package under webpack-cli, more intuitive
  • removed libraries update-notifier, semver and terser-webpack-plugin
    • semver: not needed at the moment. We use it just for one check. We already specify the engine inside the package.json
    • update-notifier: it's nice but not essential. Let's save space
    • terser-webpack-plugin: webpack already applies minification when the mode is production. Not needed
  • moved from inquirer to enquirer: smaller, less dependencies and same functionality (thank you @rishabh3112 for the suggestion)

Did you add tests for your changes?
No

If relevant, did you update the documentation?
Not needed

Summary
The cli folder doesn't respect the name inside package.json. That's why I moved it under webpack-cli folder. Also, I decided to remove some libraries that are not essential to the CLI and that could save us some space.

I also ditched inquirer for a more lighter version: enquirer. It has the same functionalities and is lighter is terms of dependencies and weight.

Does this PR introduce a breaking change?

No

Other information

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rishabh3112
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants