Skip to content

Add support for webpack2 loader options. Fixes #115. Fixes #128. #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakwuh wants to merge 3 commits into from
Closed

Add support for webpack2 loader options. Fixes #115. Fixes #128. #135

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40e39bd
Add support for webpack2 loader options. Fixes #115. Fixes #128.
Jan 16, 2017
1f93bd0
Make use of loaderUtils.getLoaderConfig
Jan 20, 2017
c58a325
Drop loader query, use loader config
Jan 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ module.exports = function(source) {
config.plugins = config.plugins.concat(this.options[configKey].lessPlugins || []);
}

// Also support webpack 2 loader.options.
if (query.lessPlugins) {

@sokra sokra Jan 20, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you refactor the config stuff to use loaderUtils.getLoaderConfig(this, "lessLoader")? This function handles the config stuff and merging.

@jakwuh jakwuh Jan 20, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

config.plugins = config.plugins.concat(query.lessPlugins);
}

// not using the `this.sourceMap` flag because css source maps are different
// @see https://github.com/webpack/css-loader/pull/40
if (query.sourceMap) {
Expand Down