Add support for webpack2 loader options. Fixes #115. Fixes #128. #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey, webpack2 released. Could you pls review this PR and merge if it's ok? |
sokra
requested changes
Jan 20, 2017
index.js
Outdated
| } | ||
|
|
||
| // Also support webpack 2 loader.options. | ||
| if (query.lessPlugins) { |
Member
There was a problem hiding this comment.
Could you refactor the config stuff to use loaderUtils.getLoaderConfig(this, "lessLoader")? This function handles the config stuff and merging.
jakwuh
force-pushed
the
master
branch
2 times, most recently
from
798e0e1 to
35264bb
Compare
Member
|
Thank your for your PR 👍, but this has been superseded by webpack/loader-utils#56 and https://github.com/webpack-contrib/less-loader/pull/147/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tests were added since it will require webpack2. However we can't still move to webpack2 since it is currently in beta.
Tested against initial tests and also locally against support for less-loader webpack2 options param.