Breaking: Make content-type rule use proper fonts types
#425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `content-type` rule uses `mime-db` which currently doesn't¹ contain the standard² font media types. This commit fixes that by introducing code that overwrites the non-standard font media types with the standard ones. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - ¹ jshttp/mime-db#77 ² https://www.iana.org/assignments/media-types/media-types.xhtml#font
alrra
requested review from
austinkelleher and
patrick-steele-idem
as code owners
molant
reviewed
Aug 15, 2017
@molant See #71 (comment).
Note yet, see #250 (we can only ignore connectors as a whole). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
content-typerule usesmime-dbwhich currently doesn't contain the standard font media types.This commit fixes that by introducing code that overwrites the non-standard font media types with the standard ones.