You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now we can ignore a rule from being run and/or tested via the ignoredCollectors properties.
Sometimes the differences are more granular and there are just some scenarios when we are testing that do not work on a specific collector and maybe it is just a question of waiting to the next release. Instead of just commenting the test (and thus not test anywhere) we should add the option to opt-out for an specific collector.
An example will be the content-type tests. Currently Chrome doesn't download JavaScript modules (it's behind a flag in v60). Also it doesn't download anything if it doesn't like the type attribute
We should also add a //TODO comment so we remove it later (hopefully once #210 is implemented so things are more automated).
I'm thinking about something similar to:
{name: `Script is served with 'Content-Type' header with the wrong media type (has 'type=text/plain' and 'js' file extension)`,reports: [{message: generateIncorrectMediaTypeMessage('application/javascript','text/plain')}],serverConfig: {'/': generateHTMLPageData(generateHTMLPage(undefined,'<script type="text/plain" src="test.js"></script>')),'/test.js': {headers: {'Content-Type': 'text/plain; charset=utf-8'}}},ignoredCollectors: ['cdp']},
@sarvaje I don't know how you are implementing the Edge Collector (#170) but if we want this to work it will need a different id and not just a config change.
@MicrosoftEdge/sonar-devs thoughts?
The text was updated successfully, but these errors were encountered:
@sarvaje I don't know how you are implementing the Edge Collector (#170) but if we want this to work it will need a different id and not just a config change.
I'm thinking to have cdp and another one... maybe eda or edge and they will share as much code as possible
molant
changed the title
Allow collector opt-out for individual tests
Allow connector opt-out for individual tests
Jul 20, 2017
After thinking a bit more, I don't think we need this. It doesn't happen that often and when we have problems we should group the failing tests and just use the regular ignoredConnectors property of testRule:
Right now we can ignore a rule from being run and/or tested via the
ignoredCollectors
properties.Sometimes the differences are more granular and there are just some scenarios when we are testing that do not work on a specific collector and maybe it is just a question of waiting to the next release. Instead of just commenting the test (and thus not test anywhere) we should add the option to opt-out for an specific collector.
An example will be the
content-type
tests. Currently Chrome doesn't download JavaScript modules (it's behind a flag in v60). Also it doesn't download anything if it doesn't like thetype
attributeWe should also add a
//TODO
comment so we remove it later (hopefully once #210 is implemented so things are more automated).I'm thinking about something similar to:
@sarvaje I don't know how you are implementing the Edge Collector (#170) but if we want this to work it will need a different id and not just a config change.
@MicrosoftEdge/sonar-devs thoughts?
The text was updated successfully, but these errors were encountered: