Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Build HTML parser with other parsers in global script #1308

Closed
wants to merge 2 commits into from
Closed

Chore: Build HTML parser with other parsers in global script #1308

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd5f470
Chore: Build HTML parser with other parsers in global script
antross Sep 12, 2018
411c0ff
Chore: Explicitly build `parser-html` before `connector-local`
antross Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@
"name": "@hint/monorepo",
"private": true,
"scripts": {
"build": "yarn clean && yarn build:hint && yarn build:utils && yarn build:connectors && npm-run-all --parallel build::parser:* && yarn build:utils-test && loop \"yarn build\" --cwd packages/ --exclude configuration-progressive-web-apps,configuration-web-recommended,connector-edge,hint,utils-debugging-protocol-common,utils-connector-tools,utils-tests-helpers,connector-chrome,connector-jsdom,parser-babel-config,parser-javascript,parser-manifest,parser-typescript-config,parser-webpack-config",
"build": "yarn clean && yarn build:hint && yarn build:utils && yarn build:connectors && npm-run-all --parallel build:parser:* && yarn build:utils-test && loop \"yarn build\" --cwd packages/ --exclude configuration-progressive-web-apps,configuration-web-recommended,connector-edge,hint,utils-debugging-protocol-common,utils-connector-tools,utils-tests-helpers,connector-chrome,connector-jsdom,parser-babel-config,parser-html,parser-javascript,parser-manifest,parser-typescript-config,parser-webpack-config",
Copy link
Contributor

@alrra alrra Sep 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parser-html should be build before connector-local.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically that should already happen as connector-local is built in loop, not as part of build:connectors.

Probably best to be explicit, though. I'll re-order these to run build:parser:* before build:connectors and add connector-local to the build:connectors step.

Sound good?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to be explicit

Yes, I think it's better to have it more explicit. Thanks!

"build:parser:babel": "cd packages/parser-babel-config && yarn build",
"build:parser:html": "cd packages/parser-html && yarn build",
"build:parser:js": "cd packages/parser-javascript && yarn build",
"build:parser:manifest": "cd packages/parser-manifest && yarn build",
"build:parser:ts": "cd packages/parser-typescript-config && yarn build",
Expand Down