Chore: Build HTML parser with other parsers in global script #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency and to ensure it gets built before connector-local.
alrra
reviewed
Sep 12, 2018
package.json
Outdated
| @@ -27,8 +27,9 @@ | |||
| "name": "@hint/monorepo", | |||
| "private": true, | |||
| "scripts": { | |||
| "build": "yarn clean && yarn build:hint && yarn build:utils && yarn build:connectors && npm-run-all --parallel build::parser:* && yarn build:utils-test && loop \"yarn build\" --cwd packages/ --exclude configuration-progressive-web-apps,configuration-web-recommended,connector-edge,hint,utils-debugging-protocol-common,utils-connector-tools,utils-tests-helpers,connector-chrome,connector-jsdom,parser-babel-config,parser-javascript,parser-manifest,parser-typescript-config,parser-webpack-config", | |||
| "build": "yarn clean && yarn build:hint && yarn build:utils && yarn build:connectors && npm-run-all --parallel build:parser:* && yarn build:utils-test && loop \"yarn build\" --cwd packages/ --exclude configuration-progressive-web-apps,configuration-web-recommended,connector-edge,hint,utils-debugging-protocol-common,utils-connector-tools,utils-tests-helpers,connector-chrome,connector-jsdom,parser-babel-config,parser-html,parser-javascript,parser-manifest,parser-typescript-config,parser-webpack-config", | |||
There was a problem hiding this comment.
parser-html should be build before connector-local.
There was a problem hiding this comment.
Technically that should already happen as connector-local is built in loop, not as part of build:connectors.
Probably best to be explicit, though. I'll re-order these to run build:parser:* before build:connectors and add connector-local to the build:connectors step.
Sound good?
There was a problem hiding this comment.
Probably best to be explicit
Yes, I think it's better to have it more explicit. Thanks!
Includes adding `connector-local` to the `build:connectors` task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)
For consistency and to ensure it gets built before connector-local.