Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Unminified JS points to the same file in repeated warnings #2898

Closed
digitarald opened this issue Aug 31, 2019 · 1 comment · Fixed by #2923
Closed

[Bug] Unminified JS points to the same file in repeated warnings #2898

digitarald opened this issue Aug 31, 2019 · 1 comment · Fixed by #2923
Assignees
@antross
Labels
area:browser-extension type:bug
Milestone
1909-1

Comments

@digitarald
Copy link

Breakout from #2896, see STR.

Performance points out inline JS as issue, 4 times the same file

hint 1: JavaScript content should be minified.
https://www.figma.com/file/Zl3RrMFmDnVBmeQg2Jy5Mv/DevPhoton?node-id=0%3A1
hint 2: JavaScript content should be minified.
https://www.figma.com/file/Zl3RrMFmDnVBmeQg2Jy5Mv/DevPhoton?node-id=0%3A1
hint 3: JavaScript content should be minified.
https://www.figma.com/file/Zl3RrMFmDnVBmeQg2Jy5Mv/DevPhoton?node-id=0%3A1
hint 4: JavaScript content should be minified.
https://www.figma.com/file/Zl3RrMFmDnVBmeQg2Jy5Mv/DevPhoton?node-id=0%3A1
@digitarald digitarald changed the title [Bug] Bug description [Bug] Unminified JS points to the same file in repeated warnings Aug 31, 2019
@digitarald digitarald mentioned this issue Aug 31, 2019
Closed
11 tasks
@antross
Copy link
Member

antross commented Sep 3, 2019

I think it's referring to separate inline <script> tags, though clearly the output doesn't provide enough context to narrow down which one. The fact that this is reporting at all may be related to #2645.

I think a couple of fixes are probably needed here:

  1. Ignore scripts below a minimum length by default
  2. Include a reference to the offending script element in the report

@antross antross added this to the 1909-1 milestone Sep 3, 2019
@antross antross self-assigned this Sep 4, 2019
antross added a commit to antross/hint that referenced this issue Sep 4, 2019
@antross
Fix: Improve minified JavaScript reports
3aeea67 
Include reference to `<script>` element in reports for inline scripts.
Also ignore scripts below 1KB (which are prone to false-positives).

- - - - - - - - - -

Fix webhintio#2898
Ref webhintio#2645
@antross antross mentioned this issue Sep 4, 2019
Merged
4 tasks
antross added a commit that referenced this issue Sep 5, 2019
@antross
Fix: Improve minified JavaScript reports
017bb35 
Include reference to `<script>` element in reports for inline scripts.
Also ignore scripts below 1KB (which are prone to false-positives).

- - - - - - - - - -

Fix #2898
Fix #2645
Close #2923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antross antross

Labels
area:browser-extension type:bug
Projects
None yet
Milestone
1909-1
Development

Successfully merging a pull request may close this issue.

Fix: Improve minified JavaScript reports antross/hint
2 participants
@digitarald @antross