Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] HTML compat data in shows mixed set of browser formats #2896

Closed
8 of 11 tasks
digitarald opened this issue Aug 31, 2019 · 1 comment · Fixed by #2978
Closed
8 of 11 tasks

[Bug] HTML compat data in shows mixed set of browser formats #2896

digitarald opened this issue Aug 31, 2019 · 1 comment · Fixed by #2978

Comments

@digitarald
Copy link

digitarald commented Aug 31, 2019

🐛 Bug report

Description

Ran webhint with ie11 off on figma.

hint 1: link[rel=preload] is not supported by and_ff 67, firefox 60, 66-68. has 2 issues:

  1. and_ff 67 is an unexpected format
  2. (Filed as [Bug] link[rel=preload] should not trigger warnings #2897) link[rel=preload] is a progressive enhancement that should not cause warnings

(Filed as #2898) Performance points out inline JS as issue, 4 times the same file

hint 1: JavaScript content should be minified.
https://www.figma.com/file/Zl3RrMFmDnVBmeQg2Jy5Mv/DevPhoton?node-id=0%3A1
hint 2: JavaScript content should be minified.
https://www.figma.com/file/Zl3RrMFmDnVBmeQg2Jy5Mv/DevPhoton?node-id=0%3A1
hint 3: JavaScript content should be minified.
https://www.figma.com/file/Zl3RrMFmDnVBmeQg2Jy5Mv/DevPhoton?node-id=0%3A1
hint 4: JavaScript content should be minified.
https://www.figma.com/file/Zl3RrMFmDnVBmeQg2Jy5Mv/DevPhoton?node-id=0%3A1

Environment

  • webhint version: 0.0.7
  • Browser version: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0
  • URL for which webhint failed:

webhint configuration

webhint’s configuration

Categories:

  • Accessibility
  • Compatibility
  • Performance
  • Pitfalls
  • PWA
  • Security

Your target browsers:

  • Recommended settings
  • Custom: defaults, not IE 11

Ignored resources:

    • None
    • Different origin
    • Custom:
@antross
Copy link
Member

antross commented Sep 3, 2019

Thanks @digitarald!

I agree the displayed browser names could be a bit more user-friendly. We're currently picking these up from browserslist, but as we already map them internally to mdn-browser-compat-data I suspect we could pick up and use the name property from there as well.

@antross antross added this to the 1909-1 milestone Sep 3, 2019
@antross antross self-assigned this Sep 10, 2019
antross added a commit to antross/hint that referenced this issue Sep 13, 2019
antross added a commit to antross/hint that referenced this issue Sep 13, 2019
Names are pulled from mdn-browser-compat-data.
Versions now focus on when a feature was added/removed.

- - - - - - - - - -

Fix webhintio#2896
antross added a commit that referenced this issue Sep 14, 2019
Names are pulled from mdn-browser-compat-data.
Versions now focus on when a feature was added/removed.

- - - - - - - - - -

Fix #2896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants