Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooling): upgraded node version from 14 to 20 #222

Merged
merged 9 commits into from
Jul 18, 2024
Merged

fix(tooling): upgraded node version from 14 to 20 #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
69d9e47
fix(tooling): upgraded node version from 14 to 20
Kesari3008 Jul 9, 2024
a60fef8
fix(tooling): updating node version in circle ci
Kesari3008 Jul 9, 2024
d5664d7
fix(tooling): latest code merge
Kesari3008 Jul 9, 2024
5a0ae0f
fix(tooling): updating circle ci
Kesari3008 Jul 9, 2024
42ee671
fix(tooling): updating circle ci
Kesari3008 Jul 9, 2024
209e12f
fix(tooling): react version fix
Kesari3008 Jul 9, 2024
9d4ece4
fix(tooling): removed @wdio/sync package
Kesari3008 Jul 17, 2024
11c6301
fix(tooling): adding force to avoid dependency conflict
Kesari3008 Jul 17, 2024
3718ee9
fix(tooling): adding check to accpet node 20 and above
Kesari3008 Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ executors:
node-executor:
working_directory: ~/widgets
docker:
- image: circleci/node:fermium-browsers
- image: cimg/node:20.13.1-browsers
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-18 at 1 04 42 PM
fermium was node-14. I think iron would be 20. Do you think we use iron here instead of the version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using iron, but it didn't work. I couldn't find circle ci image name with node:iron-browsers


# reusable command for all jobs
commands:
Expand All @@ -27,7 +27,7 @@ jobs:
- dependency-cache-{{ checksum "package-lock.json" }}
- run:
name: Install Dependencies
command: npm i
command: npm i --force #Remove force once webex version is upgraded in sdk-component-adapter
sreenara marked this conversation as resolved.
Show resolved Hide resolved
- save_cache:
key: dependency-cache-{{ checksum "package-lock.json" }}
paths: node_modules
Expand Down
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
lts/fermium
lts/iron
Loading