Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooling): upgraded node version from 14 to 20 #222

Merged
merged 9 commits into from
Jul 18, 2024
Merged

fix(tooling): upgraded node version from 14 to 20 #222

merged 9 commits into from
Jul 18, 2024

Conversation

Kesari3008
Copy link
Contributor

@Kesari3008 Kesari3008 commented Jul 9, 2024 •
edited
Loading

Upgrading node version from 14 to 20.

https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-501675

Tests Performed:

  1. Joined meeting as a licensed user.
  2. Guest joining a meeting with a password and captcha.
Screenshot 2024-07-18 at 10 47 07 AM
  1. Guest joining the meeting as host by entering host key.
Screenshot 2024-07-18 at 10 47 17 AM 4. Joined meeting using SIP destination, personID and meeting link.

sreenara
sreenara reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@sreenara sreenara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a question about the change in the pipeline config.

.circleci/config.yml Show resolved Hide resolved
Shreyas281299
Shreyas281299 approved these changes Jul 18, 2024
View reviewed changes
Copy link

@Shreyas281299 Shreyas281299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 non blocking ask

.circleci/config.yml
@@ -5,7 +5,7 @@ executors:
node-executor:
working_directory: ~/widgets
docker:
- image: circleci/node:fermium-browsers
- image: cimg/node:20.13.1-browsers
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-18 at 1 04 42 PM
fermium was node-14. I think iron would be 20. Do you think we use iron here instead of the version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using iron, but it didn't work. I couldn't find circle ci image name with node:iron-browsers

@Kesari3008 Kesari3008 merged commit 6ac4733 into webex:master Jul 18, 2024
1 check passed
sreenara pushed a commit that referenced this pull request Jul 23, 2024
@webex-components-publisher
chore(release): 1.26.4 [skip ci]
a959da8 
## [1.26.4](v1.26.3...v1.26.4) (2024-07-23)

### Bug Fixes

* **tooling:** fixed the demo build ([#224](#224)) ([487b698](487b698))
* **tooling:** upgraded node version from 14 to 20 ([#222](#222)) ([6ac4733](6ac4733))
@sreenara
Copy link
Contributor

🎉 This PR is included in version 1.26.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Kesari3008 Kesari3008 deleted the SPARK-501675-Upgrade-node-version branch November 6, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreenara sreenara sreenara approved these changes

@Shreyas281299 Shreyas281299 Shreyas281299 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kesari3008 @sreenara @Shreyas281299