feat(Webinar) - Locus API and DTO update for Webinar #3972
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,8 @@ export interface VideoProperties { | |
|
|
||
| export interface ViewTheParticipantListProperties { | ||
| enabled?: boolean; | ||
| panelistEnabled?: boolean; | ||
| attendeeCount?: boolean; | ||
|
Comment on lines
+39
to
+40
There was a problem hiding this comment. 💡 Codebase verification Missing test coverage for webinar control properties. The properties 🔗 Analysis chainVerify integration with webinar functionality and FedRAMP compliance. Since these properties are part of webinar controls, let's verify their integration: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check usage of new properties and related webinar functionality
# Check for usage of these properties in the codebase
echo "Checking usage of new properties..."
rg -t typescript "panelistEnabled|attendeeCount" packages/@webex/plugin-meetings/
# Check for webinar-related test coverage
echo "Checking test coverage..."
rg -t typescript "describe.*ViewTheParticipantList" packages/@webex/plugin-meetings/test/
# Check for FedRAMP compliance documentation
echo "Checking FedRAMP documentation..."
fd -t f "README|SECURITY" packages/@webex/plugin-meetings/
Length of output: 735 Script: #!/bin/bash
# Description: Check usage of new properties and related webinar functionality with corrected file types
# Check for usage of these properties in the codebase
echo "Checking usage of new properties..."
rg --type-add 'ts=**/*.ts' --type-add 'tsx=**/*.tsx' -t ts -t tsx "panelistEnabled|attendeeCount" packages/@webex/plugin-meetings/
# Check for webinar-related test coverage
echo "Checking test coverage..."
rg --type-add 'ts=**/*.ts' --type-add 'tsx=**/*.tsx' -t ts -t tsx "describe.*ViewTheParticipantList" packages/@webex/plugin-meetings/test/
# Check for FedRAMP compliance documentation
echo "Checking FedRAMP documentation..."
fd -t f 'README|SECURITY' packages/@webex/plugin-meetings/
Length of output: 883 Script: #!/bin/bash
# Description: Check usage of new properties and related webinar functionality by searching .ts and .tsx files
# Check for usage of these properties in the codebase
echo "Checking usage of new properties..."
rg "panelistEnabled|attendeeCount" packages/@webex/plugin-meetings/ --glob "*.ts" --glob "*.tsx"
# Check for webinar-related test coverage
echo "Checking test coverage..."
rg "describe.*ViewTheParticipantList" packages/@webex/plugin-meetings/test/ --glob "*.ts" --glob "*.tsx"
# Check for FedRAMP compliance documentation
echo "Checking FedRAMP documentation..."
fd -t f 'README|SECURITY' packages/@webex/plugin-meetings/
Length of output: 2319 |
||
| } | ||
|
|
||
| export type Properties = | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -217,6 +217,18 @@ class Utils { | |
| if (control.properties.enabled === false) { | ||
| requiredHints.push(DISPLAY_HINTS.DISABLE_VIEW_THE_PARTICIPANT_LIST); | ||
| } | ||
| if (control.properties.panelistEnabled === true) { | ||
| requiredHints.push(DISPLAY_HINTS.ENABLE_VIEW_THE_PARTICIPANT_LIST_PANELIST); | ||
| } | ||
| if (control.properties.panelistEnabled === false) { | ||
| requiredHints.push(DISPLAY_HINTS.DISABLE_VIEW_THE_PARTICIPANT_LIST_PANELIST); | ||
| } | ||
| if (control.properties.attendeeCount === true) { | ||
| requiredHints.push(DISPLAY_HINTS.ENABLE_SHOW_ATTENDEE_COUNT); | ||
| } | ||
| if (control.properties.attendeeCount === false) { | ||
| requiredHints.push(DISPLAY_HINTS.DISABLE_SHOW_ATTENDEE_COUNT); | ||
| } | ||
|
|
||
| return Utils.hasHints({requiredHints, displayHints}); | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,7 +79,11 @@ ControlsUtils.parse = (controls: any) => { | |
| } | ||
|
|
||
| if (controls?.viewTheParticipantList) { | ||
| parsedControls.viewTheParticipantList = { | ||
| enabled: controls.viewTheParticipantList?.enabled ?? false, | ||
| panelistEnabled: controls.viewTheParticipantList?.panelistEnabled ?? false, | ||
| attendeeCount: controls.viewTheParticipantList?.attendeeCount ?? 0, | ||
| }; | ||
| } | ||
|
|
||
| if (controls?.raiseHand) { | ||
|
|
@@ -90,6 +94,23 @@ ControlsUtils.parse = (controls: any) => { | |
| parsedControls.video = {enabled: controls.video.enabled}; | ||
| } | ||
|
|
||
| if (controls?.webcastControl) { | ||
| parsedControls.webcastControl = {streaming: controls.webcastControl.streaming}; | ||
| } | ||
|
|
||
| if (controls?.meetingFull) { | ||
| parsedControls.meetingFull = { | ||
| meetingFull: controls.meetingFull?.meetingFull ?? false, | ||
| meetingPanelistFull: controls.meetingFull?.meetingPanelistFull ?? false, | ||
| }; | ||
| } | ||
|
|
||
| if (controls?.practiceSession) { | ||
| parsedControls.practiceSession = { | ||
| enabled: controls.practiceSession.enabled, | ||
| }; | ||
| } | ||
|
|
||
| return parsedControls; | ||
| }; | ||
|
|
||
|
|
@@ -121,7 +142,11 @@ ControlsUtils.getControls = (oldControls: any, newControls: any) => { | |
| previous?.reactions?.showDisplayNameWithReactions, | ||
|
|
||
| hasViewTheParticipantListChanged: | ||
| current?.viewTheParticipantList?.enabled !== previous?.viewTheParticipantList?.enabled || | ||
| current?.viewTheParticipantList?.panelistEnabled !== | ||
| previous?.viewTheParticipantList?.panelistEnabled || | ||
| current?.viewTheParticipantList?.attendeeCount !== | ||
| previous?.viewTheParticipantList?.attendeeCount, | ||
|
|
||
| hasRaiseHandChanged: current?.raiseHand?.enabled !== previous?.raiseHand?.enabled, | ||
|
|
||
|
|
@@ -167,6 +192,23 @@ ControlsUtils.getControls = (oldControls: any, newControls: any) => { | |
| hasVideoEnabledChanged: | ||
| newControls.video?.enabled !== undefined && | ||
| !isEqual(previous?.videoEnabled, current?.videoEnabled), | ||
|
|
||
| hasWebcastChanged: !isEqual( | ||
| previous?.webcastControl?.streaming, | ||
| current?.webcastControl?.streaming | ||
| ), | ||
|
|
||
| hasMeetingFullChanged: | ||
| !isEqual(previous?.meetingFull?.meetingFull, current?.meetingFull?.meetingFull) || | ||
| !isEqual( | ||
| previous?.meetingFull?.meetingPanelistFull, | ||
| current?.meetingFull?.meetingPanelistFull | ||
| ), | ||
|
|
||
| hasPracticeSessionEnabledChanged: !isEqual( | ||
| previous?.practiceSession?.enabled, | ||
| current?.practiceSession?.enabled | ||
| ), | ||
| }, | ||
| }; | ||
| }; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ FullState.parse = (fullState) => ({ | |
| type: fullState.type || FULL_STATE.UNKNOWN, | ||
| meetingState: fullState.state, | ||
| locked: fullState.locked, | ||
| attendeeCount: typeof fullState.attendeeCount === 'number' ? fullState.attendeeCount : 0, | ||
|
There was a problem hiding this comment. 🛠️ Refactor suggestion Consider improving type safety and default value handling. While the type check for
Consider applying these changes: - const FullState: any = {};
+ interface FullStateData {
+ type: string;
+ state?: string;
+ locked?: boolean;
+ attendeeCount?: number;
+ }
+
+ interface ParsedFullState {
+ type: string;
+ meetingState: string | undefined;
+ locked: boolean | undefined;
+ attendeeCount: number | undefined;
+ }
+
+ const FullState = {
+ parse(fullState: FullStateData): ParsedFullState => ({
type: fullState.type || FULL_STATE.UNKNOWN,
meetingState: fullState.state,
locked: fullState.locked,
- attendeeCount: typeof fullState.attendeeCount === 'number' ? fullState.attendeeCount : 0,
+ attendeeCount: typeof fullState.attendeeCount === 'number' ? fullState.attendeeCount : undefined,
});
+ };
|
||
| }); | ||
|
|
||
| FullState.getFullState = (oldFullState, newFullState) => { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,6 +64,7 @@ export default class LocusInfo extends EventsScope { | |
| replace: any; | ||
| url: any; | ||
| services: any; | ||
| resources: any; | ||
| mainSessionLocusCache: any; | ||
| /** | ||
| * Constructor | ||
|
|
@@ -263,6 +264,7 @@ export default class LocusInfo extends EventsScope { | |
| this.updateHostInfo(locus.host); | ||
| this.updateMediaShares(locus.mediaShares); | ||
| this.updateServices(locus.links?.services); | ||
| this.updateResources(locus.links?.resources); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -452,6 +454,7 @@ export default class LocusInfo extends EventsScope { | |
| this.updateIdentifiers(locus.identities); | ||
| this.updateEmbeddedApps(locus.embeddedApps); | ||
| this.updateServices(locus.links?.services); | ||
| this.updateResources(locus.links?.resources); | ||
| this.compareAndUpdate(); | ||
| // update which required to compare different objects from locus | ||
| } | ||
|
|
@@ -805,6 +808,9 @@ export default class LocusInfo extends EventsScope { | |
| hasRaiseHandChanged, | ||
| hasVideoChanged, | ||
| hasInterpretationChanged, | ||
| hasWebcastChanged, | ||
| hasMeetingFullChanged, | ||
| hasPracticeSessionEnabledChanged, | ||
| }, | ||
| current, | ||
| } = ControlsUtils.getControls(this.controls, controls); | ||
|
|
@@ -1008,6 +1014,30 @@ export default class LocusInfo extends EventsScope { | |
| ); | ||
| } | ||
|
|
||
| if (hasWebcastChanged) { | ||
| this.emitScoped( | ||
| {file: 'locus-info', function: 'updateControls'}, | ||
| LOCUSINFO.EVENTS.CONTROLS_WEBCAST_CHANGED, | ||
| {state: current.webcastControl} | ||
| ); | ||
| } | ||
|
|
||
| if (hasMeetingFullChanged) { | ||
| this.emitScoped( | ||
| {file: 'locus-info', function: 'updateControls'}, | ||
| LOCUSINFO.EVENTS.CONTROLS_MEETING_FULL_CHANGED, | ||
| {state: current.meetingFull} | ||
| ); | ||
| } | ||
|
|
||
| if (hasPracticeSessionEnabledChanged) { | ||
| this.emitScoped( | ||
| {file: 'locus-info', function: 'updateControls'}, | ||
| LOCUSINFO.EVENTS.CONTROLS_PRACTICE_SESSION_STATUS_UPDATED, | ||
| {state: current.practiceSession} | ||
| ); | ||
| } | ||
|
|
||
| this.controls = controls; | ||
| } | ||
| } | ||
|
|
@@ -1064,6 +1094,27 @@ export default class LocusInfo extends EventsScope { | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * @param {Object} resources | ||
| * @returns {undefined} | ||
| * @memberof LocusInfo | ||
| */ | ||
| updateResources(resources: Record<'webcastInstance', {url: string}>) { | ||
| if (resources && !isEqual(this.resources, resources)) { | ||
| this.resources = resources; | ||
| this.emitScoped( | ||
| { | ||
| file: 'locus-info', | ||
| function: 'updateResources', | ||
| }, | ||
| LOCUSINFO.EVENTS.LINKS_RESOURCES, | ||
| { | ||
| resources, | ||
| } | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @param {Object} fullState | ||
| * @returns {undefined} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,6 +64,10 @@ interface IInMeetingActions { | |
| canUpdateShareControl?: boolean; | ||
| canEnableViewTheParticipantsList?: boolean; | ||
| canDisableViewTheParticipantsList?: boolean; | ||
| canEnableViewTheParticipantsListPanelist?: boolean; | ||
| canDisableViewTheParticipantsListPanelist?: boolean; | ||
| canEnableShowAttendeeCount?: boolean; | ||
| canDisableShowAttendeeCount?: boolean; | ||
| canEnableRaiseHand?: boolean; | ||
| canDisableRaiseHand?: boolean; | ||
| canEnableVideo?: boolean; | ||
|
|
@@ -83,6 +87,8 @@ interface IInMeetingActions { | |
| canShareWhiteBoard?: boolean; | ||
| enforceVirtualBackground?: boolean; | ||
| canPollingAndQA?: boolean; | ||
| canStartWebcast?: boolean; | ||
| canStopWebcast?: boolean; | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -201,6 +207,14 @@ export default class InMeetingActions implements IInMeetingActions { | |
|
|
||
| canDisableViewTheParticipantsList = null; | ||
|
|
||
| canEnableViewTheParticipantsListPanelist = null; | ||
|
|
||
| canDisableViewTheParticipantsListPanelist = null; | ||
|
|
||
| canEnableShowAttendeeCount = null; | ||
|
|
||
| canDisableShowAttendeeCount = null; | ||
|
|
||
| canEnableRaiseHand = null; | ||
|
|
||
| canDisableRaiseHand = null; | ||
|
|
@@ -238,6 +252,10 @@ export default class InMeetingActions implements IInMeetingActions { | |
| canShareWhiteBoard = null; | ||
|
|
||
| canPollingAndQA = null; | ||
|
|
||
| canStartWebcast = null; | ||
|
|
||
| canStopWebcast = null; | ||
| /** | ||
| * Returns all meeting action options | ||
| * @returns {Object} | ||
|
|
@@ -298,6 +316,10 @@ export default class InMeetingActions implements IInMeetingActions { | |
| canUpdateShareControl: this.canUpdateShareControl, | ||
| canEnableViewTheParticipantsList: this.canEnableViewTheParticipantsList, | ||
| canDisableViewTheParticipantsList: this.canDisableViewTheParticipantsList, | ||
| canEnableViewTheParticipantsListPanelist: this.canEnableViewTheParticipantsListPanelist, | ||
| canDisableViewTheParticipantsListPanelist: this.canDisableViewTheParticipantsListPanelist, | ||
| canEnableShowAttendeeCount: this.canEnableShowAttendeeCount, | ||
| canDisableShowAttendeeCount: this.canDisableShowAttendeeCount, | ||
| canEnableRaiseHand: this.canEnableRaiseHand, | ||
| canDisableRaiseHand: this.canDisableRaiseHand, | ||
| canEnableVideo: this.canEnableVideo, | ||
|
|
@@ -317,6 +339,8 @@ export default class InMeetingActions implements IInMeetingActions { | |
| supportHDV: this.supportHDV, | ||
| canShareWhiteBoard: this.canShareWhiteBoard, | ||
| canPollingAndQA: this.canPollingAndQA, | ||
| canStartWebcast: this.canStartWebcast, | ||
| canStopWebcast: this.canStopWebcast, | ||
| }); | ||
|
|
||
| /** | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider adding a Role enum for type safety
While the type definition is more specific now, consider creating an enum for valid roles to prevent runtime errors from invalid role strings.