Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON't merge(Test) #3943

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

DON't merge(Test) #3943

wants to merge 4 commits into from

Conversation

arun3528
Copy link
Collaborator

@arun3528 arun3528 commented Oct 29, 2024

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

< DESCRIBE THE CONTEXT OF THE ISSUE >

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

Summary by CodeRabbit

  • New Features

    • Introduced a new "Contact Center" sample link in the documentation.
    • Added a web-based contact center application with user authentication and UI management.
    • Created a new HTML file for a Meetings Plugin sample with interactive UI elements.
    • Implemented a ContactCenter class for managing connections to the contact center service.
  • Documentation

    • Added comprehensive README for the @webex/plugin-cc package, covering setup, development, and usage.
    • Included a new TypeScript configuration for the @webex/plugin-cc package.
  • Bug Fixes

    • Enhanced error handling and connection management in the Mercury plugin and related services.
  • Tests

    • Added unit tests for the AgentConfig, AgentConfigService, HttpRequest, and WebSocket classes to ensure robust functionality.

@arun3528 arun3528 requested review from a team as code owners October 29, 2024 19:05
Copy link

coderabbitai bot commented Oct 29, 2024

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Files that changed from the base of the PR and between a807933 and 16afa54.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (40)
  • docs/index.html (1 hunks)
  • docs/samples/contact-center/app.js (1 hunks)
  • docs/samples/contact-center/index.html (1 hunks)
  • docs/samples/contact-center/style.css (1 hunks)
  • packages/@webex/internal-plugin-mercury/src/mercury.js (3 hunks)
  • packages/@webex/internal-plugin-mercury/src/socket/socket-base.js (4 hunks)
  • packages/@webex/internal-plugin-mercury/test/unit/spec/mercury.js (1 hunks)
  • packages/@webex/internal-plugin-mercury/test/unit/spec/socket.js (3 hunks)
  • packages/@webex/plugin-cc/README.md (1 hunks)
  • packages/@webex/plugin-cc/babel.config.json (1 hunks)
  • packages/@webex/plugin-cc/jest.config.js (1 hunks)
  • packages/@webex/plugin-cc/package.json (1 hunks)
  • packages/@webex/plugin-cc/src/AgentConfig/AgentConfig.ts (1 hunks)
  • packages/@webex/plugin-cc/src/AgentConfig/constants.ts (1 hunks)
  • packages/@webex/plugin-cc/src/AgentConfig/types.ts (1 hunks)
  • packages/@webex/plugin-cc/src/AgentConfigService/AgentConfigService.ts (1 hunks)
  • packages/@webex/plugin-cc/src/AgentConfigService/types.ts (1 hunks)
  • packages/@webex/plugin-cc/src/HttpRequest.ts (1 hunks)
  • packages/@webex/plugin-cc/src/WebSocket/WebSocket.ts (1 hunks)
  • packages/@webex/plugin-cc/src/WebSocket/config.ts (1 hunks)
  • packages/@webex/plugin-cc/src/WebSocket/types.ts (1 hunks)
  • packages/@webex/plugin-cc/src/cc.ts (1 hunks)
  • packages/@webex/plugin-cc/src/config.ts (1 hunks)
  • packages/@webex/plugin-cc/src/constants.ts (1 hunks)
  • packages/@webex/plugin-cc/src/index.ts (1 hunks)
  • packages/@webex/plugin-cc/src/types.ts (1 hunks)
  • packages/@webex/plugin-cc/test/unit/spec/AgentConfig/AgentConfig.ts (1 hunks)
  • packages/@webex/plugin-cc/test/unit/spec/AgentConfigService/AgentConfigService.ts (1 hunks)
  • packages/@webex/plugin-cc/test/unit/spec/HttpRequest.ts (1 hunks)
  • packages/@webex/plugin-cc/test/unit/spec/WebSocket.ts (1 hunks)
  • packages/@webex/plugin-cc/test/unit/spec/cc.ts (1 hunks)
  • packages/@webex/plugin-cc/tsconfig.json (1 hunks)
  • packages/@webex/test-helper-mock-webex/src/index.js (1 hunks)
  • packages/@webex/webex-core/src/lib/services/service-catalog.js (1 hunks)
  • packages/@webex/webex-core/test/unit/spec/services/service-catalog.js (1 hunks)
  • packages/webex/package.json (2 hunks)
  • packages/webex/src/contact-center.js (1 hunks)
  • packages/webex/src/webex.js (1 hunks)
  • tooling/lib/build.js (1 hunks)
  • webpack.config.js (1 hunks)
______________________________________________
< Looking for trouble in all the right places. >
----------------------------------------------
 \
  \   (\__/)
      (•ㅅ•)
      /   づ

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting in your project's settings in CodeRabbit to automatically approve the review once all CodeRabbit's comments are resolved.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3943.d3m3l2kee0btzx.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants