feat(contact-center): Added new package for contact-center #3883
Conversation
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "presets": [ | |||
There was a problem hiding this comment.
is there a way to avoid babel for this package ?
There was a problem hiding this comment.
Without Babel, the build gets impacted. Tried it when working on BYODS SDK, build started to fail
There was a problem hiding this comment.
i think there will be tooling changes needed to fix, just take a note and we can fix it later
There was a problem hiding this comment.
ok will have a story created to address this
There was a problem hiding this comment.
@arun3528 - Why are we trying to get rid of babel though?
There was a problem hiding this comment.
What does babel do and what happens when we remove it?
| import {WCC_API_GATEWAY} from './constants'; | ||
|
|
||
| export default class ContactCenter extends WebexPlugin implements IContactCenter { | ||
| namespace = 'WebexCC'; |
There was a problem hiding this comment.
Question.. what does this namespace do and where do we utilize it?
There was a problem hiding this comment.
Not sure, but it was being used in all the plugins. Will check and update here
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "presets": [ | |||
There was a problem hiding this comment.
@arun3528 - Why are we trying to get rid of babel though?
| import {CCConfig, IContactCenter, WebexSDK} from './types'; | ||
|
|
||
| export default class ContactCenter extends WebexPlugin implements IContactCenter { | ||
| namespace = 'WebexCC'; |
There was a problem hiding this comment.
Where is this namespace useful?
| }; | ||
| } | ||
|
|
||
| export interface WebexSDK { |
There was a problem hiding this comment.
This might not be exhaustive but a good start to get rid of all the ts-ignores in the other packages. Considering that, should we keep this somewhere common and not inside the CC SDK?
There was a problem hiding this comment.
Where do you recommend it to keep it? For now I kept it within CC SDK, because we will modify it as per CC SDK, but if we keep it in common place, the object needs to take care of all the functions and objects any package can use and then we have to take care of those type in each folder so not sure at the moment if that might introduce some sort of type errors
There was a problem hiding this comment.
We won't have to use it in other packages immediately but will help us improve by contributions from other teams. Can be inside Webex Core package or webex-common package.
If this is not too much change, we shall just keep it there and import here so that we can introduce this object to other packages also slowly and when we do so, this can be expanded
There was a problem hiding this comment.
@mkesavan13 @Kesari3008 this can be done in a future PR and if we have any other additional dependencies on the @webex/common package.
| @@ -0,0 +1,99 @@ | |||
| import {ServiceHost} from 'packages/calling/dist/types/SDKConnector/types'; | |||
There was a problem hiding this comment.
This can be taken care of in a separate PR, but do we want to depende on calling?
If we depend on calling, we should use @webex/calling in our dependency instead of directly referring to the types.
sreenara
dismissed
mkesavan13’s stale review
Kesava is on leave. Need to merge this today for other PRs.
COMPLETES #https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-558461
This pull request addresses
Added new package inside @webex folder. Contact-center package will be accessible after Webex init as webex.cc.
by making the following changes
New package is added under @webex for the contact-center. A new sample page is added for testing the contact-center package methods. Added jest config and basic tooling changes for package to build and run tests.
Change Type
The following scenarios were tested
Sample page created for the CC package and tested Webex.init using the samples page
https://github.com/user-attachments/assets/b2d98333-c903-466e-bcd7-9a74aa82cefa
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.