-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repository-3.0.json #115
Conversation
Hey, thanks for your contribution @albciff. Unfortunately, due to the specifics you mention, we'll need a core maintainer to look at this. Note to core maintainers @andidev, @fhoeben, and @sephiroth-j:
|
Ok, @treyturner thanks for the feedback |
Hi @albciff , thanks for the update and pointing out the changes in the news chromedriver versions. The plugin is able to extract only certain files, especially if they are located in subfolders. To select only certain files, use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also add the win64 driver and define fileMatchInside
for the Windows drivers
Added requested changes: * chromedriver 116.0.5845.96 for windows x64 * fileMatchInside parameter to match the chromedriver path inside the folder
Hi @sephiroth-j thanks for your comments, I added the requested changes. |
repository-3.0.json
Outdated
{ | ||
"name": "chromedriver", | ||
"platform": "windows", | ||
"bit": "32", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should be "64", otherwise it looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for this mistake, I commit a new version with this error corrected.
Corrected chromediriver 116.0.6845.96 for windows 64 bit
Signed-off-by: Ronny Perinke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to correct the order for the Mac driver so that "amd64" comes before "aarch64".
@albciff thanks for your contribution. 👍 |
Added chrome driver version 116.0.5845.96 for:
Windows
Linux
Intel mac x64
Apple Silicon mac x64
Note that since M115 chromedriver release process is integraterd with that of chrome, from the web (https://chromedriver.chromium.org/downloads/version-selection)
So the urls added changed from the https://chromedriver.storage.googleapis.com to https://edgedl.me.gvt1.com
There is also a difference in the zip structure (at least for windows), the old ones the driver is directly in the root, however in the new zip there is a root folder and driver inside.
Depends on how you are dealing with the driver, this could produce a problem like happens with the gradle plugin https://github.com/erdi/webdriver-binaries-gradle-plugin which implements a change in version 3.2 in order to solve it