Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository-3.0.json #115

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Conversation

albciff
Copy link
Contributor

@albciff albciff commented Sep 9, 2023

Added chrome driver version 116.0.5845.96 for:

Windows
Linux
Intel mac x64
Apple Silicon mac x64

Note that since M115 chromedriver release process is integraterd with that of chrome, from the web (https://chromedriver.chromium.org/downloads/version-selection)

Starting with M115 the ChromeDriver release process is integrated with that of Chrome. The latest Chrome + ChromeDriver releases per release channel (Stable, Beta, Dev, Canary) are available at the Chrome for Testing (CfT) availability dashboard. As a result, you might no longer have a need for version selection — you could choose any available CfT version and simply download the correspondingly-versioned ChromeDriver binary.

So the urls added changed from the https://chromedriver.storage.googleapis.com to https://edgedl.me.gvt1.com

There is also a difference in the zip structure (at least for windows), the old ones the driver is directly in the root, however in the new zip there is a root folder and driver inside.

Depends on how you are dealing with the driver, this could produce a problem like happens with the gradle plugin https://github.com/erdi/webdriver-binaries-gradle-plugin which implements a change in version 3.2 in order to solve it

@treyturner
Copy link
Collaborator

Hey, thanks for your contribution @albciff. Unfortunately, due to the specifics you mention, we'll need a core maintainer to look at this.

Note to core maintainers @andidev, @fhoeben, and @sephiroth-j:

  • I no longer consume this repo but am happy to keep reviewing & merging simple PRs from the general public as I am able
  • Even when I did consume this repo I did so via erdi's Gradle plugin, so I have no context for whether the Maven plugin requires updating to account for the changes specified in this PR
  • Based on what you decide here I can review and approve similar Chromedriver update PRs in the future if/as appropriate

@albciff
Copy link
Contributor Author

albciff commented Sep 10, 2023

Ok, @treyturner thanks for the feedback

@sephiroth-j sephiroth-j self-requested a review September 10, 2023 18:29
@sephiroth-j
Copy link
Member

Hi @albciff , thanks for the update and pointing out the changes in the news chromedriver versions. The plugin is able to extract only certain files, especially if they are located in subfolders. To select only certain files, use the fileMatchInside property. For examples, see the entries for the drivers "operadriver" or "phantomjs".

Copy link
Member

@sephiroth-j sephiroth-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add the win64 driver and define fileMatchInside for the Windows drivers

Added requested changes:

* chromedriver 116.0.5845.96 for windows x64
* fileMatchInside parameter to match the chromedriver path inside the folder
@albciff
Copy link
Contributor Author

albciff commented Sep 12, 2023

Hi @sephiroth-j thanks for your comments, I added the requested changes.

@albciff albciff requested a review from sephiroth-j September 12, 2023 06:29
{
"name": "chromedriver",
"platform": "windows",
"bit": "32",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be "64", otherwise it looks good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for this mistake, I commit a new version with this error corrected.

Corrected chromediriver 116.0.6845.96 for windows 64 bit
@albciff albciff requested a review from sephiroth-j September 26, 2023 09:15
Copy link
Member

@sephiroth-j sephiroth-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to correct the order for the Mac driver so that "amd64" comes before "aarch64".

@sephiroth-j sephiroth-j merged commit 8d99e91 into webdriverextensions:master Sep 26, 2023
@sephiroth-j
Copy link
Member

@albciff thanks for your contribution. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants