Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra folder in ChromeDriver zip file in v115 #39

Closed
askucins opened this issue Jul 22, 2023 · 3 comments
Closed

Extra folder in ChromeDriver zip file in v115 #39

askucins opened this issue Jul 22, 2023 · 3 comments

Comments

@askucins
Copy link

askucins commented Jul 22, 2023

Recently I've updated the version of ChromeDriver in my tests to 115.0.5790.102 which, as suggested on https://chromedriver.chromium.org/downloads required also slightly different urls - that part went just fine - com.github.erdi.webdriver-binaries in version 3.1 picked that new chromedriver and unzipped it.

But here the problems starts - in the logs of my tests there is this:

Driver info: driver.version: CustomizedChromeDriver
org.openqa.selenium.remote.NoSuchDriverException: chromedriver located at /home/askuci/.gradle/webdriver/chromedriver/115.0.5790.102/chromedriver-linux64/b167mo42xtxmk2zrfv1mlr05x/chromedriver, but invalid

and indeed, there is an extra folder in that zip file (so the same exists after it's extracted), like:

askuci@nighthawk:~/tmp/chromedriver$ /home/askuci/.gradle/webdriver/chromedriver/115.0.5790.102/chromedriver-linux64/b167mo42xtxmk2zrfv1mlr05x/chromedriver-linux64/chromedriver -version
ChromeDriver 115.0.5790.102 (90efd4b0ad6aa15eeafcdabd5817ae939f7ba059-refs/branch-heads/5790_90@{#9})

Please compare the content of v114 vs v115

v114

askuci@nighthawk:~/tmp/chromedriver$ zipinfo -1 chromedriver_linux64-114.zip 
chromedriver
LICENSE.chromedriver

v115

askuci@nighthawk:~/tmp/chromedriver$ zipinfo -1 chromedriver-linux64-115.zip 
chromedriver-linux64/LICENSE.chromedriver
chromedriver-linux64/chromedriver

Is there maybe any quick fix I can do to this on my side? (I mean of course manually copying that chromedriver to the parent folder worked just fine, but I mean something less manual so to speak :)

@erdi
Copy link
Owner

erdi commented Aug 1, 2023

One workaround that comes to my mind is to repack v115 to not contain the additional directory, upload it to a location accessible by the build and then use a custom driver urls configuration json file pointing at the custom location with repacked zip for v115.

@erdi
Copy link
Owner

erdi commented Aug 8, 2023

Fixed in #40.

@erdi erdi closed this as completed Aug 8, 2023
@askucins
Copy link
Author

askucins commented Aug 9, 2023

It works now like a charm! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants