Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 4.4.0 #6709

Merged
merged 17 commits into from
Jan 17, 2024
Merged

release 4.4.0 #6709

merged 17 commits into from
Jan 17, 2024

Conversation

luu-alex
Copy link
Contributor

[4.4.0]

Added

web3-eth

Changed

web3-eth-abi

web3-eth-contract

web3

  • Dependencies updated

Fixed

web3-eth-abi

web3-eth-accounts

web3-eth-contract

web3-utils

web3-validator

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@luu-alex luu-alex added Release 4.x 4.0 related labels Jan 10, 2024
Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff51bd0
Status: ✅  Deploy successful!
Preview URL: https://9e1ed15d.web3-js-docs.pages.dev
Branch Preview URL: https://release-4-4-0.web3-js-docs.pages.dev

View logs

Copy link

github-actions bot commented Jan 10, 2024

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 618 KB 618 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 601 KB 601 KB 0 0.00%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.89 KB 3.89 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 999 bytes 999 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

Copy link

github-actions bot commented Jan 10, 2024

Benchmark

Benchmark suite Current: ff51bd0 Previous: 6c075db Ratio
processingTx 9543 ops/sec (±3.79%) 9301 ops/sec (±4.81%) 0.97
processingContractDeploy 42617 ops/sec (±6.55%) 39129 ops/sec (±7.62%) 0.92
processingContractMethodSend 20604 ops/sec (±6.63%) 19443 ops/sec (±5.19%) 0.94
processingContractMethodCall 40093 ops/sec (±6.01%) 38971 ops/sec (±6.34%) 0.97
abiEncode 47853 ops/sec (±6.50%) 44252 ops/sec (±6.92%) 0.92
abiDecode 32549 ops/sec (±7.81%) 30419 ops/sec (±8.89%) 0.93
sign 1724 ops/sec (±1.04%) 1656 ops/sec (±4.08%) 0.96
verify 383 ops/sec (±0.64%) 373 ops/sec (±0.78%) 0.97

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Merging #6709 (ff51bd0) into 4.x (1eb07d1) will not change coverage.
Report is 3 commits behind head on 4.x.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6709   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         214      214           
  Lines        8171     8171           
  Branches     2200     2200           
=======================================
  Hits         7520     7520           
  Misses        651      651           
Flag Coverage Δ
UnitTests 92.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@luu-alex
Copy link
Contributor Author

7 suites failing
Failing tests:
E2E Network Tests (http, sepolia)
get_balance
test/e2e/sepolia/call.test.ts

E2E Network Tests (http, mainnet)
FAIL test/e2e/get_balance.test.ts
● Test suite failed to run
FAIL test/e2e/get_transaction_count.test.ts

Integration (18, geth, http)
web3-eth: FAIL test/integration/web3_eth/estimate_gas.test.ts

Integration (18, geth, ws)
web3Eth.estimateGas › should estimate a contract deployment
same with geth http node 16, geth ws node 16

Benchmark Tests (18)

@luu-alex
Copy link
Contributor Author

Fixed e2e network tests, failing from #6689 updated in release PR
Estimate gas tests should be fixed from Oleksiis PR that was recently merged

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, unit tests should be passing before release.

@luu-alex luu-alex merged commit 7b97011 into 4.x Jan 17, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants