Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with detecting Uint8Array #6486

Conversation

Muhammad-Altabba
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba commented Oct 6, 2023

Description

Fix error: value "..." at "/0" must pass "bytes" validation.

[UPDATE: sorry it tagged an unrelated issue by mistake. Now I correct it]
Suppose to close: #6393

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@Muhammad-Altabba Muhammad-Altabba changed the title Fix issue with detecting Uint8Array Fix an issue with detecting Uint8Array Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 591 KB 618 KB 27.5 KB 4.65%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 573 KB 601 KB 27.5 KB 4.79%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.89 KB 3.89 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 999 bytes 999 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7ec6a95
Status: ✅  Deploy successful!
Preview URL: https://35d48ab5.web3-js-docs.pages.dev
Branch Preview URL: https://6393-web3validatorerror-erro.web3-js-docs.pages.dev

View logs

@Muhammad-Altabba
Copy link
Contributor Author

Muhammad-Altabba commented Oct 6, 2023

To resume working on this after merging: #6398

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #6486 (7ec6a95) into 4.x (23d69ba) will decrease coverage by 0.02%.
The diff coverage is 89.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6486      +/-   ##
==========================================
- Coverage   91.46%   91.44%   -0.03%     
==========================================
  Files         214      214              
  Lines        8155     8171      +16     
  Branches     2193     2200       +7     
==========================================
+ Hits         7459     7472      +13     
- Misses        696      699       +3     
Flag Coverage Δ
UnitTests 91.44% <89.74%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on issue desc, is this PR for #6461? or for browser events issue?

Copy link

github-actions bot commented Jan 3, 2024

Benchmark

Benchmark suite Current: 7ec6a95 Previous: 6c075db Ratio
processingTx 9395 ops/sec (±4.25%) 9301 ops/sec (±4.81%) 0.99
processingContractDeploy 41272 ops/sec (±6.92%) 39129 ops/sec (±7.62%) 0.95
processingContractMethodSend 19358 ops/sec (±7.72%) 19443 ops/sec (±5.19%) 1.00
processingContractMethodCall 40015 ops/sec (±5.61%) 38971 ops/sec (±6.34%) 0.97
abiEncode 45963 ops/sec (±6.23%) 44252 ops/sec (±6.92%) 0.96
abiDecode 31664 ops/sec (±7.86%) 30419 ops/sec (±8.89%) 0.96
sign 1635 ops/sec (±3.31%) 1656 ops/sec (±4.08%) 1.01
verify 378 ops/sec (±1.38%) 373 ops/sec (±0.78%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@Muhammad-Altabba Muhammad-Altabba merged commit 2a40b66 into 4.x Jan 8, 2024
61 of 66 checks passed
@Muhammad-Altabba Muhammad-Altabba deleted the 6393-web3validatorerror-error-value-at-0-must-pass-bytes-validation branch January 8, 2024 09:09
@luu-alex luu-alex mentioned this pull request Jan 10, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web3ValidatorError error when use sendSignedTransaction on HB blockchain
4 participants