-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue with detecting Uint8Array #6486
Fix an issue with detecting Uint8Array #6486
Conversation
…ndefined-is-not-a-constructor-or-null
…ndefined-is-not-a-constructor-or-null
…ndefined-is-not-a-constructor-or-null
…ndefined-is-not-a-constructor-or-null
…ndefined-is-not-a-constructor-or-null
…ndefined-is-not-a-constructor-or-null
…ndefined-is-not-a-constructor-or-null
(fix: `value "..." at "/0" must pass "bytes" validation`)
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with Cloudflare Pages
|
…s-not-a-constructor-or-null' into 6393-web3validatorerror-error-value-at-0-must-pass-bytes-validation
To resume working on this after merging: #6398 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6486 +/- ##
==========================================
- Coverage 91.46% 91.44% -0.03%
==========================================
Files 214 214
Lines 8155 8171 +16
Branches 2193 2200 +7
==========================================
+ Hits 7459 7472 +13
- Misses 696 699 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on issue desc, is this PR for #6461? or for browser events issue?
…-pass-bytes-validation
…-pass-bytes-validation
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
…-pass-bytes-validation
…-pass-bytes-validation
Description
Fix error:
value "..." at "/0" must pass "bytes" validation
.[UPDATE: sorry it tagged an unrelated issue by mistake. Now I correct it]
Suppose to close: #6393
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.