Copy subscription before altering the keys.#84
Merged
Conversation
2 tasks
Chris-V
force-pushed
the
clone_subscriptions
branch
4 times, most recently
from
c0ec898 to
2e95413
Compare
Altering subscriptions reference by changing the keys from string to byte causes hard to debug issues in libraries. For exemple, trying to call `json.dumps()` after initializing `WebPusher` throws an error because json cannot handle bytes.
jrconlin
approved these changes
Jan 3, 2018
Member
jrconlin
left a comment
jrconlin
left a comment
There was a problem hiding this comment.
crap. This is exactly the sort of thing I yell about myself. Thanks!
|
Any chance this could be released to PyPi? |
|
Thanks! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Altering subscriptions reference by changing the keys from string to
byte causes hard to debug issues in libraries. For exemple, trying to
call
json.dumps()after initializingWebPusherthrows an errorbecause json cannot handle bytes.