Fix push subscription serialization error#11437
Closed
Chris-V wants to merge 1 commit into
Closed
Conversation
Chris-V
force-pushed
the
fix_html5_json_bytes
branch
from
82aa093 to
2838071
Compare
Chris-V
changed the title
Chris-V
force-pushed
the
fix_html5_json_bytes
branch
from
2838071 to
ea311c1
Compare
Chris-V
force-pushed
the
fix_html5_json_bytes
branch
from
ea311c1 to
9febab6
Compare
Member
|
I just added a comment to your PR on pywebpush asking for a release. Let's give them a couple of days. Otherwise we'll merge this PR as it stands. Could you add a link to your PR as a comment to the line with deepcopy. That way if we merge this PR as-is, we know where to check if we can remove it. |
balloob
approved these changes
Jan 6, 2018
PyWebPush updates the subscription reference held by home assistant with a byte encoded value. This causes errors the next time we try to save html5_push_registrations.conf. As a workaround, I do a deepcopy of the registration dictionary before giving it to PyWebPush.
Chris-V
force-pushed
the
fix_html5_json_bytes
branch
from
9febab6 to
eaa5595
Compare
Contributor
Author
|
Comment added! |
Contributor
Author
|
pywebpush has been released. I opened a new PR with the upgrade: #11497 |
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
PyWebPush updates the subscription reference held by home assistant with a byte encoded value. This causes errors the next time we try to save html5_push_registrations.conf. As a workaround, I do a deepcopy of the registration dictionary before giving it to PyWebPush.
I opened a PR in PyWebPush with the actual fix (web-push-libs/pywebpush#84) and it got accepted. So there are two other options here. Either:
Related issue (if applicable):
fixes #10751
fixes #11024
Pull request in home-assistant.github.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):N/A
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass