Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for URLSearchParams handling of non-ASCII keys in the record<> ctor, #5813

Merged
merged 1 commit into from
May 5, 2017
Merged

Add a test for URLSearchParams handling of non-ASCII keys in the record<> ctor, #5813

merged 1 commit into from
May 5, 2017

Conversation

jgraham
Copy link
Contributor

@jgraham jgraham commented May 5, 2017 •
edited by wpt-pr-bot
Loading

@jgraham
Copy link
Contributor Author

jgraham commented May 5, 2017

Code reviewed upstream.

@jgraham jgraham merged commit 96612a8 into master May 5, 2017
@wpt-pr-bot wpt-pr-bot added the url label May 5, 2017
@jgraham jgraham deleted the sync_54c3502d7b5e443777e808a88d35b82ab1a7b6fa branch May 5, 2017 17:33
@TimothyGu TimothyGu mentioned this pull request May 14, 2017
Closed
3 tasks
TimothyGu added a commit to TimothyGu/node that referenced this pull request May 31, 2017
@TimothyGu
url: more precise URLSearchParams constructor
67d56cc 
Refs: web-platform-tests/wpt#5813
jasnell pushed a commit to nodejs/node that referenced this pull request Jun 1, 2017
@TimothyGu @jasnell
url: more precise URLSearchParams constructor
95eef9b 
PR-URL: #13026
Ref: web-platform-tests/wpt#5813
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit to nodejs/node that referenced this pull request Jun 5, 2017
@TimothyGu @jasnell
url: more precise URLSearchParams constructor
315c3aa 
PR-URL: #13026
Ref: web-platform-tests/wpt#5813
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikewest mikewest Awaiting requested review from mikewest

@zcorpan zcorpan Awaiting requested review from zcorpan

@domenic domenic Awaiting requested review from domenic

@annevk annevk Awaiting requested review from annevk

Assignees
No one assigned
Labels
url
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgraham @wpt-pr-bot @bakulf