url: more precise URLSearchParams constructor #13026
Conversation
nodejs-github-bot
added
dont-land-on-v4.x
whatwg-url
|
Previously I saw noticeable performance impacts when using a helper function like this, you may want to benchmark it vs. explicitly inlining. |
lib/internal/url.js
Outdated
| // Returns true if `val` is of the spec Object type (including functions), but | ||
| // false if `val` is of the spec Null type. | ||
| function isObject(val) { | ||
| return (typeof val === 'object' && val !== null) || typeof val === 'function'; |
There was a problem hiding this comment.
If we do want a helper function..this seems to be equivalent to !util.isPrimitive(val)?
lib/internal/url.js
Outdated
| key = toUSVString(key); | ||
| const value = toUSVString(init[key]); | ||
| this[searchParams].push(key, value); | ||
| for (const key of Reflect.ownKeys(init)) { |
There was a problem hiding this comment.
would likely be faster to use a normal for-n loop here
There was a problem hiding this comment.
@jasnell Did you mean for-in? I think that one doesn't give you the property symbols.
There was a problem hiding this comment.
I mean..
const keys = Reflect.ownKeys(init);
for (var n = 0; n < keys.length; n++) {
// ...
}
| @@ -156,7 +167,8 @@ test(function() { | |||
| [ | |||
| { "input": {"+": "%C2"}, "output": [["+", "%C2"]], "name": "object with +" }, | |||
| { "input": {c: "x", a: "?"}, "output": [["c", "x"], ["a", "?"]], "name": "object with two keys" }, | |||
| { "input": [["c", "x"], ["a", "?"]], "output": [["c", "x"], ["a", "?"]], "name": "array with two keys" } | |||
| { "input": [["c", "x"], ["a", "?"]], "output": [["c", "x"], ["a", "?"]], "name": "array with two keys" }, | |||
There was a problem hiding this comment.
long lines here. does this pass lint?
There was a problem hiding this comment.
This is from WPT so it's wrapped in eslint-disable
TimothyGu
force-pushed
the
urlsearchparams-record
branch
from
66bc147
to
2fefc33
Compare
Unfortunately this is true for this PR as well. Now the checks are specifically inlined. New CI: https://ci.nodejs.org/job/node-test-pull-request/8218/ |
| @@ -226,6 +246,8 @@ test(() => { | |||
| assert.throws(() => new URLSearchParams([['a', obj]]), /^Error: toString$/); | |||
| assert.throws(() => new URLSearchParams(sym), | |||
| /^TypeError: Cannot convert a Symbol value to a string$/); | |||
| assert.throws(() => new URLSearchParams({ [sym]: 'a' }), | |||
| /^TypeError: Cannot convert a Symbol value to a string$/); | |||
There was a problem hiding this comment.
perhaps create the regex once and reuse it?
lib/internal/url.js
Outdated
| @@ -817,7 +817,8 @@ class URLSearchParams { | |||
| constructor(init = undefined) { | |||
| if (init === null || init === undefined) { | |||
| this[searchParams] = []; | |||
| } else if (typeof init === 'object') { | |||
| } else if (typeof init === 'object' && init !== null || | |||
| typeof init === 'function') { | |||
There was a problem hiding this comment.
Not sure how others feel, but I prefer to use parentheses when I’m mixing logical and and logical or because I can never remember the precedence rules. ;)
TimothyGu
force-pushed
the
urlsearchparams-record
branch
from
2fefc33
to
67d56cc
Compare
PR-URL: #13026 Ref: web-platform-tests/wpt#5813 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 95eef9b |
PR-URL: #13026 Ref: web-platform-tests/wpt#5813 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: web-platform-tests/wpt#5813
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url