Add description guidelines for default styles #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbeck
requested review from
foolip and
captainbrosset
and removed request for
foolip
foolip
requested changes
Jul 22, 2024
docs/README.md
Outdated
| @@ -192,6 +192,17 @@ Avoid. | |||
| See [sets](#sets). | |||
| ([#727](https://github.com/web-platform-dx/web-features/pull/727#discussion_r1537635491)) | |||
|
|
|||
| ##### typically styled as … by default | |||
|
|
|||
| Use this phrase (or a closely similarly one like "typically styled in") to note unspecified but conventional browser default styling. | |||
There was a problem hiding this comment.
The default styling is actually specified in detail and quite interoperable. For <small>, it's here:
https://html.spec.whatwg.org/multipage/rendering.html#phrasing-content-3
I think I'd prefer us to say just "by default" for these cases.
There was a problem hiding this comment.
Oh fascinating! That's worth amending over. Changes forthcoming
github-actions
bot
added
the
feature definition
foolip
reviewed
Jul 23, 2024
docs/README.md
Outdated
| @@ -192,6 +192,17 @@ Avoid. | |||
| See [sets](#sets). | |||
| ([#727](https://github.com/web-platform-dx/web-features/pull/727#discussion_r1537635491)) | |||
|
|
|||
| ##### styled as … by default | |||
There was a problem hiding this comment.
I've suggested a small change of your approach and updated this PR to reflect it. I will monitor for additional feedback. 😄
Merged
foolip
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1381 and #1379, this would bless a specific way to talk about default styles, when common and relevant.