Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <cite>, <p>, <pre>, and <q> #1381

Merged
merged 10 commits into from
Jul 19, 2024
Merged

Conversation

petele
Copy link
Collaborator

@petele petele commented Jul 11, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 11, 2024
features/p.yml Outdated Show resolved Hide resolved
features/pre.yml Outdated Show resolved Hide resolved
features/q.yml Outdated Show resolved Hide resolved
features/cite.yml Outdated Show resolved Hide resolved
features/cite.yml Outdated Show resolved Hide resolved
features/pre.yml Outdated Show resolved Hide resolved
@petele
Copy link
Collaborator Author

petele commented Jul 15, 2024

updated based on feedback

@petele
Copy link
Collaborator Author

petele commented Jul 16, 2024

@foolip & @ddbeck - this is failing with the error:
/features/cite: must have required property 'status'

Do we need to add status to all features now? And if so, what is the value we should set there?

@petele petele requested a review from ddbeck July 16, 2024 13:50
@foolip
Copy link
Collaborator

foolip commented Jul 16, 2024

@petele yes, status is required. But you don't need to write one yourself, just generate the dist file with npm run dist and commit it. In this PR they've been removed instead of moved, and that's the problem.

@petele
Copy link
Collaborator Author

petele commented Jul 16, 2024

@petele yes, status is required.

Ah - got it. From the error message, it wasn't clear if the error was in the .yml file, or the .yml.dist file, and I assumed it should be in the .yml.

Fixed.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm suggesting the group changes for consistency with #1467. But after those changes are applied, this is ready.

name: <cite>
description: The `<cite>` element TODO.
description: The `<cite>` element represents the title of a quoted, referenced, or mentioned creative work, such as a film or book.
spec: https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-cite-element
group: html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
group: html
group: html-elements

features/p.yml Outdated
name: <p>
description: The `<p>` element TODO.
description: The `<p>` element represents a paragraph of text.
spec: https://html.spec.whatwg.org/multipage/grouping-content.html#the-p-element
group: html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
group: html
group: html-elements

features/pre.yml Outdated
name: <pre>
description: The `<pre>` element TODO.
description: The `<pre>` element represents a block element of preformatted text that is presented exactly as written, including all white space.
spec: https://html.spec.whatwg.org/multipage/grouping-content.html#the-pre-element
group: html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
group: html
group: html-elements

features/q.yml Outdated
name: <q>
description: The `<q>` element TODO.
description: The `<q>` element represents a short inline quotation.
spec: https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-q-element
group: html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
group: html
group: html-elements

@ddbeck
Copy link
Collaborator

ddbeck commented Jul 19, 2024

@petele you read my mind on the group changes! Thank you!

@ddbeck ddbeck merged commit 4c6d1e6 into web-platform-dx:main Jul 19, 2024
3 checks passed
@petele petele deleted the elem-pre-p branch July 25, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants