-
-
Notifications
You must be signed in to change notification settings - Fork 19
fix: coverage cannot includes parent folders #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| import path from 'node:path'; | ||
| import type { GlobOptions } from 'tinyglobby'; | ||
| import { withDefaultConfig } from '../../src/config'; | ||
| import { getIncludedFiles } from '../../src/coverage/generate'; | ||
|
|
||
| describe('getIncludedFiles', () => { | ||
| let defaultExclude: string[] = []; | ||
| let memfs!: GlobOptions['fs']; | ||
| beforeAll(async () => { | ||
| const { fs } = await import('memfs'); | ||
| defaultExclude = withDefaultConfig({}).coverage.exclude; | ||
| memfs = fs as any; | ||
|
|
||
| // There's a bug in tinyglobby: if the computed common root path cannot be the root of the Windows volume, the root path will be resolved to pwd. | ||
| [ | ||
| '/root/apps/a.ts', | ||
| '/root/apps/b.js', | ||
| '/root/apps/.c.ts', | ||
| '/root/apps/node_modules/a.ts', | ||
| '/root/apps/dist/a.ts', | ||
| '/root/apps/test/a.ts', | ||
| '/root/apps/__tests__/a.ts', | ||
| '/root/apps/__mocks__/a.ts', | ||
| '/root/apps/a.d.ts', | ||
| '/root/apps/a.test.ts', | ||
| '/root/apps/a.spec.ts', | ||
| '/root/apps/a.test.js', | ||
| '/root/apps/a.spec.js', | ||
| '/root/apps/a.test.mts', | ||
| '/root/apps/a.spec.mts', | ||
| '/root/apps/a.test.cts', | ||
| '/root/apps/a.spec.cts', | ||
| '/root/apps/a.test.tsx', | ||
| '/root/apps/a.spec.tsx', | ||
| '/root/packages/a.ts', | ||
| '/root/packages/b.js', | ||
| '/root/packages/.c.ts', | ||
| ].forEach((file) => { | ||
| fs.mkdirSync(path.dirname(file), { recursive: true }); | ||
| fs.writeFileSync(file, ''); | ||
| }); | ||
| }); | ||
|
|
||
| const glob = async (include: string[], exclude: string[] = []) => { | ||
| const files = await getIncludedFiles( | ||
| { | ||
| include, | ||
| exclude: [...defaultExclude, ...exclude], | ||
| }, | ||
| '/root/apps', | ||
| memfs, | ||
| ); | ||
| // ensure consistent paths across platforms | ||
| return files | ||
| .map((file) => path.relative('/root', file).replaceAll(path.sep, '/')) | ||
| .sort(); | ||
| }; | ||
|
|
||
| it('should include visible files by default', async () => { | ||
| expect( | ||
| await glob(['**/*.{js,ts}', '../packages/*.{js,ts}']), | ||
| ).toMatchInlineSnapshot(` | ||
| [ | ||
| "apps/a.ts", | ||
| "apps/b.js", | ||
| "packages/a.ts", | ||
| "packages/b.js", | ||
| ] | ||
| `); | ||
| }); | ||
|
|
||
| it('should include hidden files if explicitly specified', async () => { | ||
| expect(await glob(['**/*.{js,ts}', '**/.c.ts'])).toMatchInlineSnapshot(` | ||
| [ | ||
| "apps/.c.ts", | ||
| "apps/a.ts", | ||
| "apps/b.js", | ||
| ] | ||
| `); | ||
| }); | ||
|
|
||
| it('should exclude node_modules, dist, test, __tests__, __mocks__ by default', async () => { | ||
| expect(await glob(['**/*'])).toMatchInlineSnapshot(` | ||
| [ | ||
| "apps/a.ts", | ||
| "apps/b.js", | ||
| ] | ||
| `); | ||
| }); | ||
|
|
||
| it('should exclude .d.ts files by default', async () => { | ||
| expect(await glob(['**/*.d.ts'])).toMatchInlineSnapshot('[]'); | ||
| }); | ||
|
|
||
| it('should exclude test and spec files by default', async () => { | ||
| expect(await glob(['**/*.{test,spec}.*'])).toMatchInlineSnapshot('[]'); | ||
| }); | ||
| }); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alphabetical reordering of dependencies in package.json is not related to the bug fix and should be separated into its own commit or PR. Mixing code formatting/organization changes with functional changes makes it harder to review and understand what's actually necessary for the fix.
The only functional change needed here is adding
"memfs": "^4.51.1"to devDependencies. The reordering of existing entries like moving@types/chai,chai,pathe,birpc, etc. is purely cosmetic.