Skip to content

Conversation

@claneo
Copy link
Collaborator

@claneo claneo commented Dec 31, 2025

Summary

The first test case result expected:

[
  "/apps/a.ts",
  "/apps/b.js",
  "/packages/a.ts",
  "/packages/b.js",
]

but got:

[
  "/packages/.c.ts",
  "/packages/a.ts",
  "/packages/b.js",
]

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Dec 31, 2025

Deploy Preview for rstest-dev ready!

Name Link
🔨 Latest commit 46b14bf
🔍 Latest deploy log https://app.netlify.com/projects/rstest-dev/deploys/6959cd96de96a7000878bd77
😎 Deploy Preview https://deploy-preview-825--rstest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@claneo claneo force-pushed the fix-coverage-include branch from 71015d5 to 46b14bf Compare January 4, 2026 02:16
@claneo claneo marked this pull request as ready for review January 4, 2026 02:38
Copilot AI review requested due to automatic review settings January 4, 2026 02:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the coverage exclude pattern **/[.]* was incorrectly matching and excluding parent folder references in glob patterns. The fix removes this problematic pattern from the default excludes and adjusts the glob configuration to handle hidden files appropriately.

  • Removes **/[.]* from default coverage exclude patterns
  • Removes dot: true from glob options in coverage generation to prevent matching hidden files by default
  • Adds comprehensive tests to verify coverage includes files from parent directories correctly

Reviewed changes

Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/core/src/config.ts Removes **/[.]* from default coverage exclude patterns
packages/core/src/coverage/generate.ts Exports getIncludedFiles for testing, removes dot: true option, and adds optional fs parameter for dependency injection
packages/core/tests/coverage/include.test.ts Adds comprehensive test suite verifying parent folder inclusion and hidden file handling
website/docs/en/config/test/coverage.mdx Updates documentation to reflect removed exclude pattern
website/docs/zh/config/test/coverage.mdx Updates Chinese documentation to reflect removed exclude pattern
packages/core/tests/core/__snapshots__/rstest.test.ts.snap Updates snapshots to remove **/[.]* pattern
packages/core/tests/__snapshots__/config.test.ts.snap Updates snapshot to remove **/[.]* pattern
packages/core/package.json Adds memfs dependency and reorders existing dependencies alphabetically
pnpm-lock.yaml Adds memfs@4.51.1 lockfile entry
.gitignore Allows packages/core/tests/coverage directory
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"tinyglobby": "^0.2.15",
"tinyspy": "^4.0.4",
"picomatch": "^4.0.3"
"webpack-license-plugin": "^4.5.1"
Copy link

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alphabetical reordering of dependencies in package.json is not related to the bug fix and should be separated into its own commit or PR. Mixing code formatting/organization changes with functional changes makes it harder to review and understand what's actually necessary for the fix.

The only functional change needed here is adding "memfs": "^4.51.1" to devDependencies. The reordering of existing entries like moving @types/chai, chai, pathe, birpc, etc. is purely cosmetic.

Suggested change
"webpack-license-plugin": "^4.5.1"
"webpack-license-plugin": "^4.5.1",
"memfs": "^4.51.1"

Copilot uses AI. Check for mistakes.
@9aoy
Copy link
Collaborator

9aoy commented Jan 5, 2026

👍

@9aoy 9aoy merged commit 60891ae into main Jan 5, 2026
21 checks passed
@9aoy 9aoy deleted the fix-coverage-include branch January 5, 2026 06:29
@9aoy 9aoy mentioned this pull request Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants