Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: parallelize side effects optimization #8781

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Dec 19, 2024

Summary

Refactor our implementation to more parallel friendly and incremental friendly, and parallelize it as much as possible.

Time cost on side effects optimization:

  • internal project (FS): 180ms -> 63ms
  • arco-pro: 3.5ms -> 1.9ms
  • 20000 modules: 2.9ms -> 2.9ms (basically no change since there are no connections are optimizable in this case)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Dec 19, 2024
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 6bf5d4d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6764fa12027b2800088b23f9

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #8781 will not alter performance

Comparing ahabhgk:par-side-effects (6bf5d4d) with main (22f3bb0)

Summary

✅ 1 untouched benchmarks

@ahabhgk
Copy link
Contributor Author

ahabhgk commented Dec 19, 2024

!bench

@LingyuCoder LingyuCoder merged commit e5a53a5 into web-infra-dev:main Dec 20, 2024
31 checks passed
@ahabhgk ahabhgk deleted the par-side-effects branch December 20, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants