ci: use ubuntu-22.04 (#8776)

web-infra-dev · Dec 19, 2024 · 22f3bb0 · 22f3bb0
1 parent 0e749f0
commit 22f3bb0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -62,7 +62,7 @@ jobs:
     with:
       target: x86_64-unknown-linux-gnu
       profile: "debug"
-      native: ${{ needs.get-runner-labels.outputs.LINUX_RUNNER_LABELS == '"ubuntu-latest"' }}
+      native: ${{ needs.get-runner-labels.outputs.LINUX_RUNNER_LABELS == '"ubuntu-22.04"' }}
       runner: ${{ needs.get-runner-labels.outputs.LINUX_RUNNER_LABELS }}
       skipable: ${{ needs.check-changed.outputs.changed != 'true' }}
 

diff --git a/.github/workflows/get-runner-labels.yml b/.github/workflows/get-runner-labels.yml
@@ -37,8 +37,9 @@ jobs:
             WINDOWS_RUNNER_LABELS='${{ vars.WINDOWS_RUNNER_LABELS }}';
           fi
           # set default value
+          # use ubuntu 22.04 to be compatible with playwright docker
           if [[ -z "$LINUX_RUNNER_LABELS" ]]; then
-            LINUX_RUNNER_LABELS='"ubuntu-latest"';
+            LINUX_RUNNER_LABELS='"ubuntu-22.04"';
           fi
           if [[ -z "$MACOS_RUNNER_LABELS" ]]; then
             MACOS_RUNNER_LABELS='"macos-latest"';

diff --git a/.github/workflows/reusable-build.yml b/.github/workflows/reusable-build.yml
@@ -270,6 +270,8 @@ jobs:
       - name: Run e2e
         uses: ./.github/actions/docker-run
         with:
+          # Jammy uses ubuntu 22.04
+          # If this is to change, make sure to upgrade the ubuntu version in GitHub Actions
           image: mcr.microsoft.com/playwright:v1.47.0-jammy
           # .cache is required by download artifact, and mount in ./.github/actions/docker-run
           # .tool_cache is required by pnpm