Skip to content

feat: add finishModules hook#2463

Merged
ahabhgk merged 1 commit intoweb-infra-dev:mainfrom
tuchg:feat-hook_fm
Mar 25, 2023
Merged

feat: add finishModules hook#2463
ahabhgk merged 1 commit intoweb-infra-dev:mainfrom
tuchg:feat-hook_fm

Conversation

@tuchg
Copy link
Contributor

@tuchg tuchg commented Mar 25, 2023

Summary

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2023

🦋 Changeset detected

Latest commit: f6b5129

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@rspack/binding Patch
@rspack/core Patch
@rspack/postcss-loader Patch
@rspack/cli Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/dev-client Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ahabhgk ahabhgk merged commit 9c71512 into web-infra-dev:main Mar 25, 2023
@ahabhgk
Copy link
Contributor

ahabhgk commented Mar 26, 2023

There shouldn't be an error, have you run pnpm build:binding:debug or pnpm build:binding:release.

@faga295
Copy link
Contributor

faga295 commented Mar 26, 2023

I've just realized this, it's stupid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants