-
-
Notifications
You must be signed in to change notification settings - Fork 760
feat!: remove deprecated output library fields #12745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 3 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 react-10kPath:
📦 Download Diff Report: react-10k Bundle Diff 📁 react-5kPath:
📦 Download Diff Report: react-5k Bundle Diff 📁 romePath:
📦 Download Diff Report: rome Bundle Diff Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
🎉 Size decreased by 471.25KB from 48.03MB to 47.57MB (⬇️0.96%) |
|
@codex review |
Merging this PR will not alter performance
Comparing Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8a87908dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
This PR removes deprecated output configuration fields from Rspack and migrates all test cases to use the new API format. The deprecated fields that have been removed include:
output.libraryExport- replaced withoutput.library.exportoutput.libraryTarget- replaced withoutput.library.typeoutput.umdNamedDefine- replaced withoutput.library.umdNamedDefineoutput.auxiliaryComment- replaced withoutput.library.auxiliaryCommentAll test configuration files in
tests/rspack-testhave been updated to use the newlibrary.typeformat instead oflibraryTarget. The normalization logic has been simplified to only handle the new API format, and all related documentation has been updated accordingly.Checklist