fix: remove deprecated output library fields #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
There was a problem hiding this comment.
Pull request overview
This PR removes four deprecated output library configuration fields (auxiliaryComment, libraryExport, libraryTarget, and umdNamedDefine) from rspack-chain in alignment with upstream rspack changes.
Changes:
- Removed deprecated output configuration methods from the Output class
- Updated TypeScript type definitions to remove deprecated method signatures
- Removed deprecated field usage from test files
- Updated documentation to remove references to deprecated configuration options
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Output.js | Removed deprecated fields from the Output class extend array |
| types/index.d.ts | Removed deprecated method type definitions from the Output class |
| types/test/rspack-chain-tests.ts | Removed test code that used deprecated output configuration methods |
| README.md | Removed documentation for deprecated output configuration options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: web-infra-dev/rspack#12745