perf: don't drop rust compiler instance in non-watch mode#11920
Merged
perf: don't drop rust compiler instance in non-watch mode#11920
Conversation
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
team
Contributor
|
📝 Benchmark detail: Open
|
Contributor
📦 Binary Size-limit
❌ Size increased by 640bytes from 47.67MB to 47.67MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #11920 will not alter performanceComparing Summary
Footnotes |
Contributor
|
📝 Benchmark detail: Open
|
hardfist
force-pushed
the
yj/no-drop-compiler
branch
from
7df0084 to
efa8399
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes non-watch builds by avoiding costly Rust compiler teardown. It introduces an internal unsafeFastDrop flag that propagates from the CLI to the Rust binding, conditionally skipping drop in finalize to improve performance.
- Add internal unsafeFastDrop flag to Compiler and a setter on MultiCompiler; CLI sets it when not in watch mode
- Update Rust binding to wrap Compiler in ManuallyDrop and conditionally drop in finalize based on the flag
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rspack/src/MultiCompiler.ts | Adds a setter to propagate unsafeFastDrop to child compilers |
| packages/rspack/src/Compiler.ts | Adds unsafeFastDrop property and forwards it into the native binding constructor |
| packages/rspack/etc/core.api.md | Updates API report for new internal field/setter |
| packages/rspack-cli/src/cli.ts | Sets unsafeFastDrop in non-watch mode to skip drop overhead |
| crates/rspack_binding_api/src/lib.rs | Wraps Compiler in ManuallyDrop and conditionally drops in finalize |
Comments suppressed due to low confidence (1)
crates/rspack_binding_api/src/lib.rs:1
- self.compiler is ManuallyDrop; calling methods directly on it will not compile. Obtain a reference to the inner Compiler (e.g., via as_ptr) before calling id(). For example: let compiler_ref: &Compiler = unsafe { &*self.compiler.as_ptr() }; let compiler_id = compiler_ref.id();
#![recursion_limit = "256"]
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
should we need move the option into experiments? |
SyMind
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It's slow and unnecessary to drop the Compiler & Compilation in non-watch mode, so support to ignore drop of Compiler & Compilation instance in non-watch mode
Related links
Checklist