perf(build): enable unsafe fast drop in non-watch mode#6404
Merged
chenjiahan merged 1 commit intomainfrom Oct 22, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables Rspack's unsafeFastDrop optimization in non-watch mode to improve build performance. The feature is controlled via an environment variable that's automatically set when running builds without watch mode.
Key changes:
- Sets
RSPACK_UNSAFE_FAST_DROPenvironment variable to 'true' in non-watch build mode - Reads the environment variable and enables
unsafeFastDropon the compiler instance
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/cli/commands.ts | Sets the environment variable when build is not in watch mode |
| packages/core/src/provider/createCompiler.ts | Reads environment variable and enables unsafe fast drop on the compiler |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Enable Rspack's unsafe fast drop when running
rspack buildto improve build performance.Before
After
Related Links
Checklist